Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch to original fork of Bloop #3020

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

tgodzik
Copy link
Member

@tgodzik tgodzik commented Jul 11, 2024

No description provided.

@tgodzik tgodzik force-pushed the switch-bloop branch 4 times, most recently from 5d9b7c7 to dd68843 Compare July 11, 2024 18:13
@Gedochao Gedochao self-requested a review July 12, 2024 10:23
@Gedochao Gedochao added the needs-minor-release This change should require a minor version bump. label Jul 12, 2024
@tgodzik tgodzik marked this pull request as ready for review July 31, 2024 15:44
@tgodzik
Copy link
Member Author

tgodzik commented Jul 31, 2024

2.0.0-RC1 is out, we should be good to merge this after the release.

@tgodzik
Copy link
Member Author

tgodzik commented Jul 31, 2024

Sonatype issues strike again :/

@tgodzik
Copy link
Member Author

tgodzik commented Aug 8, 2024

@Gedochao do I have your blessing to merge this? The Metals PR is done

@Gedochao
Copy link
Contributor

Gedochao commented Aug 9, 2024

@Gedochao do I have your blessing to merge this? The Metals PR is done

You do, go ahead 😅

@Gedochao
Copy link
Contributor

Gedochao commented Aug 9, 2024

Ah, a rebase will be necessary, though.

@tgodzik tgodzik merged commit 42c8427 into VirtusLab:main Aug 9, 2024
79 checks passed
@tgodzik tgodzik deleted the switch-bloop branch August 9, 2024 16:13
@sideeffffect
Copy link

Huge congratulations and thanks for this achievement. Can we expect a new release of scala-cli with this anytime soon?

@Gedochao
Copy link
Contributor

Huge congratulations and thanks for this achievement. Can we expect a new release of scala-cli with this anytime soon?

Yes, the plan is to include it in the next release in ~2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-minor-release This change should require a minor version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants