-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-296] Add support for fish autocompletions #3104
[ISSUE-296] Add support for fish autocompletions #3104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I tested it out and look to work except when using completion without any input. That seems to be case app issue though and can be further improved.
Actually works fine, I had leftover code from a previous attempt. I wonder if we could get also next subcommands, it doesn't seem implemented in case app (or scala-cli?) |
Ad 3. Looks like some subcommands work, while other do not (bloop about is not suggested). Anyway looks like we can improve things further, but this already works awesome! |
@tgodzik Can you extract any issues you've found into separate issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
Funny thing, those commands do not exist in Scala CLI codebase, but they work since they are just forwarded to Bloop, which understands more commands. The question is whether they should be showed by Scala CLI? This is things like The only one I think we could add is |
Hi all, I wanted to contribute a little bit to this fantastic project so I've taken a look at your "Good first Issues" and I've decided to pick up this one.
fish
CLI.I've also ran
scala-cli
with my changes locally and installed it from scratch to test if it works: