Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-296] Add support for fish autocompletions #3104

Conversation

KristianLentino99
Copy link
Contributor

@KristianLentino99 KristianLentino99 commented Aug 14, 2024

Hi all, I wanted to contribute a little bit to this fantastic project so I've taken a look at your "Good first Issues" and I've decided to pick up this one.

  • I've updated the related test and ran all the steps mentioned in the CONTRIBUTING guidelines.
  • I've also updated the Advanced installation doc adding the tab for the new fish CLI.

I've also ran scala-cli with my changes locally and installed it from scratch to test if it works:
image

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested it out and look to work except when using completion without any input. That seems to be case app issue though and can be further improved.

@tgodzik tgodzik requested a review from Gedochao August 15, 2024 16:41
@tgodzik
Copy link
Member

tgodzik commented Aug 15, 2024

Actually works fine, I had leftover code from a previous attempt. I wonder if we could get also next subcommands, it doesn't seem implemented in case app (or scala-cli?)

@tgodzik
Copy link
Member

tgodzik commented Aug 15, 2024

Ad 3. Looks like some subcommands work, while other do not (bloop about is not suggested). Anyway looks like we can improve things further, but this already works awesome!

@Gedochao
Copy link
Contributor

Ad 3. Looks like some subcommands work, while other do not (bloop about is not suggested). Anyway looks like we can improve things further, but this already works awesome!

@tgodzik Can you extract any issues you've found into separate issues?

@Gedochao Gedochao linked an issue Aug 19, 2024 that may be closed by this pull request
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@Gedochao Gedochao merged commit 98e98b6 into VirtusLab:main Aug 19, 2024
78 checks passed
@tgodzik
Copy link
Member

tgodzik commented Aug 19, 2024

Ad 3. Looks like some subcommands work, while other do not (bloop about is not suggested). Anyway looks like we can improve things further, but this already works awesome!

@tgodzik Can you extract any issues you've found into separate issues?

Funny thing, those commands do not exist in Scala CLI codebase, but they work since they are just forwarded to Bloop, which understands more commands. The question is whether they should be showed by Scala CLI?

This is things like scala bloop projects or even scala bloop compile both of which will actually not work unless run in scala-build directory 😅

The only one I think we could add is about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fish shell completion support
3 participants