feat: implement Authenticode parsing and verification without relying on OpenSSL #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (#99) This adds deferred parsing of SignedAttributes field of SignedInfo structure within CMS, allowing us to directly access the raw data of this field so that it can be properly verified without canonical DER decoder in the way. To make things easier and avoid rewrite of as many code as possible, there's option to turn `DeferSignerInfo` structure directly into `SignerInfo` structure. On top of that, all other fields are decoded as usual, making deferred structure still useful in cases where non-deferred attributes are needed. Affected binary added to tests.
The attribute containing the nested signatures can have more than one value, each with one signature.
Instead of using `to_der_vec_raw`, which allocates a vector, use `write_der` which writes directly to the hasher.
…feature is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we were using the
authenticode-parsercrate for Authenticode parsing and verification. This is simply a Rust wrapper aroundhttps://github.com/avast/authenticode-parserwhich is written in C and uses OpenSSL under the hood. Depending on OpenSSL makes building and deploying YARA-X harder, specially when you want to integrate YARA-X in other systems.With this change all the Authenticode parsing and validation is re-written in Rust.