New Prod Dockerfiles - Test I.

Vizzuality · Aug 3, 2023 · 2c00d78 · 2c00d78
1 parent 9755044
commit 2c00d78
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/client_ci_cd.yml b/.github/workflows/client_ci_cd.yml
@@ -1,11 +1,11 @@
 name: Client CI/CD
 
 on:
+  workflow_dispatch:
   push:
     paths:
       - 'client/**'
       - '.github/workflows/client*'
-  workflow_dispatch:
 
 jobs:
   deploy:

diff --git a/.github/workflows/cms_ci_cd.yml b/.github/workflows/cms_ci_cd.yml
@@ -1,11 +1,11 @@
 name: CMS CI/CD
 
 on:
+  workflow_dispatch:
   push:
     paths:
       - 'cms/**'
       - '.github/workflows/cms*'
-  workflow_dispatch:
 
 jobs:
   deploy:

diff --git a/Dockerfile.client.prod b/Dockerfile.client.prod
@@ -1,3 +1,4 @@
+# Build all the things
 FROM node:18-alpine AS build
 RUN apk add --no-cache libc6-compat
 ENV NODE_ENV production
@@ -15,6 +16,7 @@ COPY ./client .
 
 RUN yarn build
 
+# Copy only the built files into the final image
 FROM node:18-alpine AS runner
 ENV NODE_ENV production
 ENV NEXT_TELEMETRY_DISABLED 1

diff --git a/Dockerfile.cms.prod b/Dockerfile.cms.prod
@@ -1,3 +1,4 @@
+# Build all the things
 FROM node:18-alpine as build
 RUN apk update && apk add --no-cache build-base gcc autoconf automake zlib-dev libpng-dev vips-dev > /dev/null 2>&1
 ENV NODE_ENV production
@@ -13,12 +14,13 @@ RUN yarn install
 COPY ./cms .
 RUN yarn build
 
+# Copy only the built files into the final image
 FROM node:18-alpine AS runner
 RUN apk add --no-cache vips-dev
-WORKDIR /app
-
 ENV NODE_ENV production
 
+WORKDIR /app
+
 RUN addgroup --system --gid 1001 nodejs
 RUN adduser --system --uid 1001 strapi