fix: eslint configuration #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anamontiaga
force-pushed
the
fix/eslint
branch
from
262a3fe
to
45f1a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick eslint configuration
Description
This PR includes a quick eslint configuration.
I've only reordered some test files to avoid conflicts, but from now on, every file we open will ask to reorder the imports according to the settings.
To make it more comfortable to do so, it is best to configure your vsCode so that when saving they are ordered by themselves. Just added this to your settings.json
"javascript.updateImportsOnFileMove.enabled": "always", "editor.codeActionsOnSave": { "source.fixAll.eslint": true, "source.fixAll.stylelint": true },Keep attention on SKIP_PREFLIGHT_CHECK= variable that needs to add set to true to be able to up the project locally. Not sure if we can avoid it.
I've temporarily removed the prop-type rule, but it would be wise to re-enable it and make any necessary modifications so I don't get eslint errors of that kind.