Remove [SAVE|RESTORE]_GCODE_STATE from PRINT_END macro

The sample configuration for some boards contain PRINT_END macros that include [SAVE|RESTORE]_GCODE_STATE command in them. Unfortunately, those commands may have a negative effect in that the macro tries to perform some safety moves between them to move the toolhead away from the print. However, when the GCode state is restore, Klipper will move the toolhead to the last position before the GCode state is save. This will negate the safety moves and put the toolhead back where it was. Fix this by removing the [SAVE|RESTORE]_GCODE_STATE command.
VoronDesign · Oct 27, 2023 · 05091a6 · 05091a6
1 parent 917d180
commit 05091a6
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/firmware/klipper_configurations/Octopus/Voron2_Octopus_Config.cfg b/firmware/klipper_configurations/Octopus/Voron2_Octopus_Config.cfg
@@ -559,8 +559,6 @@ gcode:
     {% set y_safe = th.position.y + 20 * (1 if th.axis_maximum.y - th.position.y > 20 else -1) %}
     {% set z_safe = [th.position.z + 2, th.axis_maximum.z]|min %}
 
-    SAVE_GCODE_STATE NAME=STATE_PRINT_END
-
     M400                           ; wait for buffer to clear
     G92 E0                         ; zero the extruder
     G1 E-5.0 F1800                 ; retract filament
@@ -573,4 +571,3 @@ gcode:
     M107                                     ; turn off fan
 
     BED_MESH_CLEAR
-    RESTORE_GCODE_STATE NAME=STATE_PRINT_END
diff --git a/firmware/klipper_configurations/SKR_1.3/Voron2_SKR_13_Config.cfg b/firmware/klipper_configurations/SKR_1.3/Voron2_SKR_13_Config.cfg
@@ -562,8 +562,6 @@ gcode:
     {% set y_safe = th.position.y + 20 * (1 if th.axis_maximum.y - th.position.y > 20 else -1) %}
     {% set z_safe = [th.position.z + 2, th.axis_maximum.z]|min %}
 
-    SAVE_GCODE_STATE NAME=STATE_PRINT_END
-
     M400                           ; wait for buffer to clear
     G92 E0                         ; zero the extruder
     G1 E-5.0 F1800                 ; retract filament
@@ -576,4 +574,3 @@ gcode:
     M107                                     ; turn off fan
 
     BED_MESH_CLEAR
-    RESTORE_GCODE_STATE NAME=STATE_PRINT_END
diff --git a/firmware/klipper_configurations/SKR_1.4/Voron2_SKR_14_Config.cfg b/firmware/klipper_configurations/SKR_1.4/Voron2_SKR_14_Config.cfg
@@ -562,8 +562,6 @@ gcode:
     {% set y_safe = th.position.y + 20 * (1 if th.axis_maximum.y - th.position.y > 20 else -1) %}
     {% set z_safe = [th.position.z + 2, th.axis_maximum.z]|min %}
 
-    SAVE_GCODE_STATE NAME=STATE_PRINT_END
-
     M400                           ; wait for buffer to clear
     G92 E0                         ; zero the extruder
     G1 E-5.0 F1800                 ; retract filament
@@ -576,4 +574,3 @@ gcode:
     M107                                     ; turn off fan
 
     BED_MESH_CLEAR
-    RESTORE_GCODE_STATE NAME=STATE_PRINT_END
diff --git a/firmware/klipper_configurations/Spider/Voron2_Spider_Config.cfg b/firmware/klipper_configurations/Spider/Voron2_Spider_Config.cfg
@@ -505,8 +505,6 @@ gcode:
     {% set y_safe = th.position.y + 20 * (1 if th.axis_maximum.y - th.position.y > 20 else -1) %}
     {% set z_safe = [th.position.z + 2, th.axis_maximum.z]|min %}
 
-    SAVE_GCODE_STATE NAME=STATE_PRINT_END
-
     M400                           ; wait for buffer to clear
     G92 E0                         ; zero the extruder
     G1 E-5.0 F1800                 ; retract filament
@@ -519,4 +517,3 @@ gcode:
     M107                                     ; turn off fan
 
     BED_MESH_CLEAR
-    RESTORE_GCODE_STATE NAME=STATE_PRINT_END