Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First upload of the RP2040 display #205

Merged
merged 27 commits into from
Jan 2, 2024
Merged

Conversation

th0mpy
Copy link
Contributor

@th0mpy th0mpy commented May 30, 2023

This is my remix of the V0_display, based on the RP2040 (RaspberryPi Pico).

Update to 2 layer board
vertical USB connector
updated fonts
Regenerated gerbers, BOM, and placement file
Changed to SMD push buttons
Copy link
Contributor

@timmit99 timmit99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files validated last night on my desktop, @bartlammers's branch has already been made and tested, good to approve!

@timmit99
Copy link
Contributor

timmit99 commented Nov 20, 2023

Got an error on the CLI action:
image

Let me take a look

Copy link
Contributor

@timmit99 timmit99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After CLI run, one error noticed.

V0_Display_RP2040/STLs/README.md Show resolved Hide resolved
@bartlammers
Copy link
Contributor

Few points of feedback:

  • You changed the USB from horizontal to vertical, but not the STL files to match. To prevent this issue, is it possible perhaps to make it compatible with the existing V0 display layout? If not also fine, but the printable files will have to match then.
  • The rear has no ground pour.
  • The buttons are changed from through-hole to SMD ones. The readme does not reflect that yet.
  • The screenshot in the readme is of the regular V0 display, not your version.
  • Text on the silkscreen is in Play, but not Play bold as is used in the Voron typography (minor issue, just noticed it)
  • If it is going to be merged into the VoronHardware repository, we would prefer to not have other logos on there besides an optional Voron logo. You can of course add your (nick)name on there instead for credit on the design.

@th0mpy
Copy link
Contributor Author

th0mpy commented Nov 20, 2023

Don't commit the changes just yet. Just a few housecleaning things to get out of the way first. In the meantime, I updated per @bartlammers suggestions.

  1. Updated (rolled back) to micro-usb for usability in both a vertical and horizontal configuration. Later update may go back to USB-C
  2. One 3.3v and one GND pour, coming up.
  3. Did some small updates to the README but will finish up with the housecleaning later (need to update pictures and such)
  4. See point 3 😄
  5. SHOULD* be all updated to PLAY BOLD. Question, do you want knockout or prefer the regular font?
  6. My logo is removed (hidden in another layer) and the Voron logo is added.

I'll get to the screenshots tonight and will push a new update as well as do just a little cleaning to tidy up the structure of the KiCad and regenerate the production files.

@th0mpy
Copy link
Contributor Author

th0mpy commented Nov 20, 2023

I made a couple updates to the schematics, per some design considerations.

  • Added a 10k pull up on the CS line to make boot-up more reliable.
  • Moved the 1k resistor for BOOTSEL closer to the chip, reducing crosstalk on the xtal and cs lines.
  • Added 3 gpio pins, consistent with the original V0 display, in the same location as the previous design.

@th0mpy
Copy link
Contributor Author

th0mpy commented Nov 21, 2023

@bartlammers all updates accounted for. Please review and let me know what you think.

modified holes for alignment on the display
Copy link
Contributor

@timmit99 timmit99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. Would it make sense to rename the KiCad files (.kicad_pcb, .kicad_sch, and .kicad_pro) from V0_Display to V0_Display_RP2040?
  2. For the STL's, If you reverted to the horizontal USB then the STLs should be 95% compatible with the stock right? (Only difference would be the back for the RP2040 specific boot buttons) If so, we can remove all duplicate files to avoid confusion!

V0_Display/KiCad/V0_Display.kicad_pro Outdated Show resolved Hide resolved
V0_Display_RP2040/Images/IMG_1685.jpeg Outdated Show resolved Hide resolved
V0_Display_RP2040/Images/IMG_1683.jpeg Outdated Show resolved Hide resolved
V0_Display_RP2040/Images/IMG_1687.jpeg Outdated Show resolved Hide resolved
V0_Display_RP2040/Images/IMG_1688.jpeg Outdated Show resolved Hide resolved
V0_Display_RP2040/Images/IMG_1691.jpeg Outdated Show resolved Hide resolved
@th0mpy
Copy link
Contributor Author

th0mpy commented Nov 28, 2023

Regarding the STLs. Yes, the Voron 0 STLs are 100% the same as before. I can just remove those STLs.

@th0mpy
Copy link
Contributor Author

th0mpy commented Nov 28, 2023

I just received a few boards yesterday with all of the changes. I'll snap a few new pics tonight and upload with updated filenames.

@th0mpy
Copy link
Contributor Author

th0mpy commented Nov 30, 2023

Images updated. Please have a look and let me know if you approve of the changes. Side note, I confirmed that the new version of KiCad will not allow you to change the extension names. It really messes things up and I had to restore from a backup. All should be good now.

@th0mpy th0mpy requested a review from timmit99 December 13, 2023 04:14
@timmit99
Copy link
Contributor

timmit99 commented Jan 2, 2024

@th0mpy
Only thing i noticed was the Neopixel out silkscreen looks to overlap. May be best to make the pin names a bit larger and shift the title up a bit.
image
(this may just be my font though, but your image looks to have the same issue)

image

Moved a couple labels and updated font size.
@th0mpy
Copy link
Contributor Author

th0mpy commented Jan 2, 2024

I updated that label.

@timmit99
Copy link
Contributor

timmit99 commented Jan 2, 2024

I updated that label.

ok great, than i see nothing else to nitpick =D

@timmit99 timmit99 merged commit 7cb8fe3 into VoronDesign:master Jan 2, 2024
1 check passed
@wlhlm
Copy link

wlhlm commented Jan 26, 2024

This PR seems to have removed V0_Display/KiCad/V0_Display.kicad_pcb, which was the PCB layout for the STM32 V0 display. Was this intentional?

@th0mpy
Copy link
Contributor Author

th0mpy commented Jan 26, 2024

The V0_Display.kicad_pcb was an accident. I've fixed it, but it still shows as a deletion in the PR.

@th0mpy
Copy link
Contributor Author

th0mpy commented Jan 26, 2024

Although, I do see that the file was indeed deleted. I can do a new pull request to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants