Renames and unit tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
commented
Aug 17, 2023
| @@ -7,13 +7,22 @@ | |||
| import glob | |||
| import logging | |||
|
|
|||
There was a problem hiding this comment.
this file change just has black formatting
ataymano
reviewed
Aug 17, 2023
ataymano
reviewed
Aug 17, 2023
rl_chain/__init__.py
Outdated
| from .pick_best_chain import ( | ||
| PickBest, | ||
| PickBestAutoSelectionScorer, | ||
| PickBestFeatureEmbedder, |
There was a problem hiding this comment.
maybe we should not expose embedders from top level?
- inheritance from them seems quite advanced scenario, so they may confuse
- not clear why inheritance from them may be needed since they have almost no state and only one function
There was a problem hiding this comment.
yeah I can remove
ataymano
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistent naming
TextEmbedder->FeatureEmbedderandto_vw_format->formatscore/scoringfor anything reward relatedactions/contextrenamed toto_select_from/based_onlabelandcost/action/probabilityrenamed toSelectionfor theLabelclass and then the variable is calledselectedin the event, which makes it nice:selected.score,selected.index,selected.probability