Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Pressed" and "Hover" textures to the Top Bar buttons #57

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

YangTegap
Copy link
Contributor

I have created hover and pressed textures for the minimize, maximize, and close buttons that matches the theme in both background color, border color, border thickness, and border radius. With the hover background, the buttons do seem a little on the small side compared to the default window buttons, it may be worth increase the size and decreasing the spacing. For now, I have kept everything set up the way it is.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your time to help us improve GoZen, we really appreciate your efforts!

@YangTegap YangTegap changed the title Added "Pressed" and "Hover" textures to the window buttons Added "Pressed" and "Hover" textures to the Top Bar buttons Oct 12, 2023
@YangTegap
Copy link
Contributor Author

A possible problem is that these buttons are set to 50% opacity under Visibility > Modulate. While the background color is set to match the button theme of the startup panel, the color does appear slightly duller due to the transparency. A possible solution would be to change the button color from white to the intended gray color, and restore the opacity to 100%.

@voylin
Copy link
Collaborator

voylin commented Oct 23, 2023

Thanks for the pull request! We don't push directly to the master branch anymore, all changes should be pushed to the development branch first.

Edit: Changing the base branch is not an option for this as it will also try to push many of the other files.

@voylin voylin changed the base branch from master to development October 23, 2023 05:47
@voylin voylin changed the base branch from development to master October 23, 2023 05:47
@aappaapp
Copy link
Collaborator

We don't push directly to the master branch anymore, all changes should be pushed to the development branch first.

Maybe state that clearly in the README.md and CONTRIBUTING.md so this won't happen next time. So what should we do with this PR now?

@voylin
Copy link
Collaborator

voylin commented Oct 23, 2023

We don't push directly to the master branch anymore, all changes should be pushed to the development branch first.

Maybe state that clearly in the README.md and CONTRIBUTING.md so this won't happen next time. So what should we do with this PR now?

Good idea! For now I'll be merging this pr and make the changes manually in the Development branch instead as there is no way to change the branch of this PR without causing issues. So overall not a big issue but was looking up what can be done about this in the future to avoid people pushing directly to master.

@voylin voylin merged commit 9b7adaf into VoylinsGamedevJourney:master Oct 23, 2023
1 check passed
@voylin
Copy link
Collaborator

voylin commented Oct 23, 2023

Made the changes in the development branch + made the default icons grey instead of setting the modulate to 126 for opacity. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants