Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external_variables missing from CMIP6_required_global_attributes #849

Closed
durack1 opened this issue Dec 19, 2019 · 5 comments · Fixed by #850 or #851
Closed

external_variables missing from CMIP6_required_global_attributes #849

durack1 opened this issue Dec 19, 2019 · 5 comments · Fixed by #850 or #851

Comments

@durack1
Copy link
Member

durack1 commented Dec 19, 2019

Following PCMDI/cmor#541 and PCMDI/cmip6-cmor-tables#278 external_variables will need to be added to the CMIP6_required_global_attributes.json

@mauzey1 @taylor13

@taylor13
Copy link
Collaborator

external_variables is only conditionally required. It is required when areacella and/or areacello and/or volcella and/or volcello are included in the cell_measures attribute. Can PrePARE do a conditional test?

In any case I think but am not sure that "required_global_attributes" includes only those that are invariably require, not conditionally required.

@durack1
Copy link
Member Author

durack1 commented Dec 19, 2019

@taylor13 good point, however I think this will need to be solved downstream as it was an omission that needed updating. @mauzey1 let me know if this is an incorrect assumption

@mauzey1
Copy link

mauzey1 commented Dec 19, 2019

@taylor13 @durack1
Okay, I will instead make a test in PrePARE that will check for external_variables if values are present in cell_measures.

Including external_variables in required_global_attributes was causing issues with other tests so we should revert that change.

@durack1
Copy link
Member Author

durack1 commented Dec 19, 2019

@mauzey1 thanks for the heads up, I had not realized how intricate this was and so will revert #849

@durack1
Copy link
Member Author

durack1 commented Dec 19, 2019

Reopening as external_variables is a conditional attribute, and consequently is causing problems when defined as required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants