-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMIP6 license per source #1066
Add CMIP6 license per source #1066
Conversation
I like what you've done in the license.json file. I'd favor making an additional tweak to the source_id file. In order to avoid "rights" in line19 above, could we use the word "license" here and then change "license" in line 15 to "license_info"? (might also consider replacing in license.json, "license_id" with "license_title" so no chance of confusing with "id" in source_id; judgement call ... I don't really care too much. If you make this change, then you'll have to also exchange the word in the first line of the file.) |
@taylor13 those changes are now in place, and the new CMIP6_CVs/CMIP6_source_id.json Lines 14 to 23 in bbd4e7d
|
@matthew-mizielinski to provide a little more guidance (and constrain the review task), it would be great if you can review all the
CMIP6_CVs/CMIP6_source_id.json Lines 4737 to 4759 in bbd4e7d
CMIP6_CVs/CMIP6_source_id.json Lines 8250 to 8285 in bbd4e7d
I believe I have added a ** Edit: it seems that the info at https://ukesm.ac.uk/licensing-of-met-office-nerc-and-niwa-cmip6-data/ provides info for ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@matthew-mizielinski those
CMIP6_CVs/CMIP6_source_id.json Lines 4737 to 4759 in 1876f6d
CMIP6_CVs/CMIP6_source_id.json Lines 8250 to 8285 in 1876f6d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to go -- I've got one comment, but that is probably more for the creation of the CV file in with the MIP tables
Have added pull request #1069 as a possible merge into this pull request (before merging to master) -- this has a prototype license table. |
@mauzey1 we have made changes in particular to the CMIP6_license.json (added a |
@durack1 Thanks for the heads up. I will checkout out how the new license options work with cmip6-cmor-tables and CMOR. |
Fix #1050
Will need to confirm whether the data found for
CMCC-ESM2-SR5
will need to be deleted, as it is not currently available through ESGF #296 - and we have notes that this was an errored publication #900Ref #1028