Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sealog-sulisCam-stills-import.py does not create aux_event_data for sulis stills #1

Open
mcschwartzman opened this issue Jan 24, 2023 · 5 comments
Assignees

Comments

@mcschwartzman
Copy link

This causes Sulis stills to not get displayed without a client UI workaround that converts the event options in the sulis events into fake aux data (https://github.com/WHOIGit/ndsf-sealog-client/blob/main/src/components/event_preview.js#L20).

We need to modify this script to create an aux_event_data entry for each sulis still (and maybe remove the event_options) and then remove the workaround linked above (to avoid displaying the image twice). We should also decide if we want to:

  1. Go through every sulis event in the db (there are likely a LOT) and create aux_event_data for it
  2. Add a check in the event_export api to see if a sulis event HAS an event_aux_data and create one if it doesn't (then use in the UI)
@figuernd
Copy link
Contributor

@jogarcia-whoi is this fixed?

@jogarcia-whoi
Copy link
Contributor

Hi, @figuernd. I don't think I've ever used this script before or been on a cruise in which Alvin used a SulisCam so I'm not sure how this script will function. Perhaps @smccue2019 can provide some input?

@ahimahis
Copy link

ahimahis commented Apr 23, 2024 via email

@smccue2019
Copy link

smccue2019 commented Apr 23, 2024 via email

@figuernd figuernd self-assigned this Oct 17, 2024
@figuernd
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants