Spec supporting trigger context ID for aggregate reporting #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
previously requested changes
Nov 21, 2023
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
approved these changes
Nov 21, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 30, 2023
reports WICG/attribution-reporting-api#1114 Trigger context ID is only allowed when source registration time is excluded. This CL introduces a wrapper type AggregatableTriggerConfig for source_registration_time_config and trigger_context_id so that these two fields can be validated together. When trigger context ID is set, the report delay will be reduced to 0, and null report rate will be increased to 1. The trigger context ID is included unencrypted in the aggregatable report. OBSOLETE_HISTOGRAMS=Conversions.TriggerRegistrationError8 is replaced by Conversions.TriggerRegistrationError9. Bug: 1504141 Change-Id: I40d09f8bb3a60b1318da8d67a7e835aeae0fb346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046773 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1231259}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #974
Explainer: #1113
Preview | Diff