Unlimited aggregatable reports with trigger context ID #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
requested changes
Oct 17, 2024
|
Please also reference #1183 in the PR description. |
Done. |
apasel422
reviewed
Oct 18, 2024
apasel422
reviewed
Oct 18, 2024
|
We should also update |
Done. |
apasel422
reviewed
Oct 24, 2024
apasel422
reviewed
Oct 24, 2024
giladbarkan-github
force-pushed
the
max_aggregate_reports
branch
from
58001bf to
3e1743a
Compare
giladbarkan-github
changed the title
apasel422
reviewed
Oct 30, 2024
| @@ -4149,7 +4149,7 @@ To <dfn>trigger aggregatable attribution</dfn> given an [=attribution trigger=] | |||
| 1. If the result of running [=check if attribution should be blocked by rate limits=] | |||
| with |trigger|, |sourceToAttribute|, and |rateLimitRecord| is not null, | |||
| return it. | |||
| 1. If |sourceToAttribute|'s [=attribution source/number of aggregatable attribution reports=] value is equal to [=max aggregatable reports per source=][0], then: | |||
| 1. If |sourceToAttribute|'s [=attribution source/number of aggregatable attribution reports=] value is equal to [=max aggregatable reports per source=][0] and |trigger|'s [=attribution trigger/trigger context ID=] is null, then: | |||
There was a problem hiding this comment.
Should we update the name and/or definition of max aggregatable reports per source to make it clear that it only applies without trigger context IDs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current hard limit on aggregatable reports per source might be too small for
some use-cases. Allowing consumers to configure it allows for more flexibility
in handling the utility implications of higher limits that would also garner
more constraints due to privacy.
(See also #1183)
Preview | Diff