Remove the source site from aggregatable reports and privacy budget key #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 31, 2022
See explainer update here: WICG/attribution-reporting-api#445 Bug: 1329588 Change-Id: I4762cf57260bd957aac08aced5acafdc3987b756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674678 Reviewed-by: John Delaney <johnidel@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009256}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 31, 2022
See explainer update here: WICG/attribution-reporting-api#445 Bug: 1329588 Change-Id: Ibe9fa953802bbafadbee342858beece19b398816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674468 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009322}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 1, 2022
…reports" This reverts commit 37319b8. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1330836#c1 Original change's description: > [attribution-reporting] remove source_site from aggregatable reports > > See explainer update here: > WICG/attribution-reporting-api#445 > > > Bug: 1329588 > Change-Id: Ibe9fa953802bbafadbee342858beece19b398816 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674468 > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1009322} Bug: 1329588 Change-Id: I72d3dc9d9041e7e84ce26949595987a12c02f52e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3683141 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1009483}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 1, 2022
…reports Reland of crrev.com/c/3674468 which was reverted in crrev.com/c/3683141. See explainer update here: WICG/attribution-reporting-api#445 Bug: 1329588 Change-Id: Ifdf77622a58640a09ecf4600741f44aac9db8887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674468 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1009322} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3682194 Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009793}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins to addresses issue #439