Align spec with implementation experience #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The constructor needs to _consume_ transient user activation, not just check it. * We need a reentrancy flag for the cancel event. * We need to not fire close if destroy() was called during the cancel event handler. * Note the discussion about the Esc key being user activation (#7).
domenic
force-pushed
the
spec-updates
branch
from
b96e092 to
c5f4382
Compare
pull bot
pushed a commit
to luojiguicai/chromium
that referenced
this pull request
Oct 19, 2021
This matches the spec after WICG/close-watcher#8. Note the outstanding question at WICG/close-watcher#7 about the Esc key; since Chromium currently does not count the Esc key as user activation, we have one particular behavior. The tracking of last user activation time ensures that any user activation allows the CloseWatcher to, in the future, fire a cancel event---not just during the transient activation duration time window. This gives the desired semantics outlined in https://github.com/WICG/close-watcher#asking-for-confirmation and https://github.com/WICG/close-watcher#abuse-analysis. Bug: 1171318 Change-Id: I34212f29539d5796b4a9bdc4c7351b9d8ea5880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168969 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#932757}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This matches the spec after WICG/close-watcher#8. Note the outstanding question at WICG/close-watcher#7 about the Esc key; since Chromium currently does not count the Esc key as user activation, we have one particular behavior. The tracking of last user activation time ensures that any user activation allows the CloseWatcher to, in the future, fire a cancel event---not just during the transient activation duration time window. This gives the desired semantics outlined in https://github.com/WICG/close-watcher#asking-for-confirmation and https://github.com/WICG/close-watcher#abuse-analysis. Bug: 1171318 Change-Id: I34212f29539d5796b4a9bdc4c7351b9d8ea5880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168969 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#932757} NOKEYCHECK=True GitOrigin-RevId: f81bb8a5905014bebe9cb4520cff7a8ac036702d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff