Fix signal specification #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually implementing this uncovered a few spec bugs. These edits largely mirror the structure in https://chromium-review.googlesource.com/c/chromium/src/+/2877951.
|
Per offline discussion I think the spec is more broken than this makes it appear. E.g. the "navigate method call promise" isn't sticking around long enough for us to reject it on aborted navigations, which is bad. It might be better to build this on top of #109 where the "navigate event side table" gives us a clear place to put the signal. |
domenic
added a commit
that referenced
this pull request
Jul 23, 2021
This commit introduces a much more robust framework for tracking ongoing navigations. This fixes #130, for example, by appropriately keeping the signal around so that we can signal abort when necessary. It also ensures every same-document navigation ends in either navigationsuccess or navigationerror, with a few unified spec paths. With this framework in hand, we can specify goTo()/back()/forward().
|
Rolling into #109. |
domenic
added a commit
that referenced
this pull request
Jul 27, 2021
This commit introduces a much more robust framework for tracking ongoing navigations. This fixes #130, for example, by appropriately keeping the signal around so that we can signal abort when necessary. It also ensures every same-document navigation ends in either navigationsuccess or navigationerror, with a few unified spec paths. With this framework in hand, we can specify goTo()/back()/forward().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually implementing this uncovered a few spec bugs. These edits largely mirror the structure in https://chromium-review.googlesource.com/c/chromium/src/+/2877951.
Preview | Diff