Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define basic address space inheritance rules. #37

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Define basic address space inheritance rules. #37

merged 3 commits into from
Dec 17, 2020

Conversation

letitz
Copy link
Collaborator

@letitz letitz commented Dec 10, 2020

This PR starts converting English language requirements into actual patches to the HTML (mostly) and Fetch (a tiny bit) specs.

It patches Fetch minimally to support defining the HTML changes, mostly by defining an address space property on fetch responses. The changes to HTML are more extensive, but I am not yet sure they are enough. I think work remains to be done on blob: URLs, and I need to check what happens during navigations to cover data: and javascript: URLs. Any pointers there are appreciated.

Along the way, I renamed address space to IP address space, aligning with the URL spec's IPv{4,6} address concepts.

This PR furthers #27 without fixing it entirely yet.

@letitz letitz requested a review from mikewest December 10, 2020 10:56
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments inline.

index.src.html Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
index.src.html Show resolved Hide resolved
index.src.html Show resolved Hide resolved
@letitz
Copy link
Collaborator Author

letitz commented Dec 15, 2020

Friendly ping 😸

Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry I lost track of this. Thanks for taking the time to do another pass or two. :)

@letitz
Copy link
Collaborator Author

letitz commented Dec 17, 2020

No worries, thanks for taking the time to review!

@letitz letitz merged commit fdb2bce into master Dec 17, 2020
@letitz letitz deleted the inherit branch February 22, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants