Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the function & attribute names Sanitizer interface and SanitizerConfig dictionary #36

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Change the function & attribute names Sanitizer interface and SanitizerConfig dictionary #36

merged 3 commits into from
Sep 18, 2020

Conversation

iVanlIsh
Copy link
Collaborator

This PR intend to:

  1. Change toString to sanitizeToString.
  2. Change toFragment to sanitize.
  3. Add CreationOptions attribute into Sanitizer interface.
  4. Change the SanitizerConfig.

otherdaniel
otherdaniel approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@otherdaniel otherdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's keep freddyb in the loop, because IIRC this partially overlaps with one of his changes.

README.md Outdated Show resolved Hide resolved
mozfreddyb
mozfreddyb reviewed Sep 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mozfreddyb
Copy link
Collaborator

mozfreddyb commented Sep 17, 2020 •
edited
Loading

please excuse the delay. looks good (but pls add the SecureContext constraint)!

@iVanlIsh iVanlIsh merged commit 83db1cb into WICG:master Sep 18, 2020
@purplesyringa purplesyringa mentioned this pull request Sep 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewest mikewest mikewest left review comments

@otherdaniel otherdaniel otherdaniel approved these changes

@mozfreddyb mozfreddyb mozfreddyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iVanlIsh @mozfreddyb @mikewest @otherdaniel