Rename "groupByOrigin" #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-by-origin should be used instead to match the naming documented in [0]. Also, switch executionMode to "USVString" to avoid the compatibility issue with "enum" described in [1]. [0] https://webidl.spec.whatwg.org/#idl-enums [1] whatwg/webidl#893
domfarolino
reviewed
Mar 9, 2023
It gets used in URLs, where validation will fail. Better to just validate earlier, in WebIDL.
|
LGTM (I can't formally approve), % OP description:
which probably just needs updated. |
Done. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 15, 2023
This came up in the context of [0]. Fields we don't parse (most non-origin and non-URL fields) should probably be DOMString instead of USVString, per [1]. [0] WICG/turtledove#479 (comment) [1] https://webidl.spec.whatwg.org/#idl-USVString Change-Id: Id7870c3c1ca2bf1bfac211a5891f89f9eee7b42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4328291 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1117759}
github-actions bot
added a commit
that referenced
this pull request
Mar 17, 2023
SHA: 4f9f55a Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group-by-origin should be used instead to match the naming documented in [0].
Also, switch executionMode to "DOMString" to avoid the compatibility issue with "enum" described in [1], and update some USVStrings to DOMString.
[0] https://webidl.spec.whatwg.org/#idl-enums
[1] whatwg/webidl#893
Preview | Diff