Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross-doc-explainer.md #211

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Update cross-doc-explainer.md #211

merged 2 commits into from
Jul 11, 2023

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Jun 25, 2023

Updated to be more precise about current thinking re. API shape.

Updated to be more precise about current thinking re. API shape.
Note that this event is different from [`pageshow`](https://html.spec.whatwg.org/#event-pageshow) as
in the newly initialized document `pageshow` is only fired once the document is fully loaded.

A potential alternative would be to expose it via `document.activeViewTransition`. This would be available only before the document
gets render-unblocked for the first time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be available only before the document gets render-unblocked for the first time.

Are you trying to say that the accessor returns null once the Document is no longer render-blocked on initial load? It's obvious this misses the activation cases but they're technically doable. Would be better to have some text clarifying why we're not proposing this syntax. Something like: "figuring out when this should be queried for activation cases, in the absence of an event, is hard"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, clarified

@noamr noamr merged commit 485cfa6 into main Jul 11, 2023
@noamr noamr deleted the noamr-patch-1 branch July 11, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants