Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document open issue around small-order checks in EdDSA #31

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

twiss
Copy link
Collaborator

@twiss twiss commented Oct 15, 2024

Document issue 27 in the spec.


Preview | Diff

Copy link
Collaborator

@Frosne Frosne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also specify what would be the problems if we skip these checks?

P.s. I am asking myself if it would make sense to extend "an invalid point or a small-order element" with "non-canonically encoded points"?

@twiss
Copy link
Collaborator Author

twiss commented Oct 15, 2024

Should we also specify what would be the problems if we skip these checks?

I think since there's a link to the issue with further discussion; hopefully that's sufficient..?

P.s. I am asking myself if it would make sense to extend "an invalid point or a small-order element" with "non-canonically encoded points"?

Rejecting non-canonical points is already required by RFC8032, AFAIU. That doesn't necessarily mean that every implementation does so, but that's a separate issue...

Copy link
Collaborator

@Frosne Frosne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@twiss twiss merged commit ec94372 into main Oct 15, 2024
2 checks passed
@twiss twiss deleted the document-issue-27 branch October 15, 2024 14:51
github-actions bot added a commit that referenced this pull request Oct 15, 2024
SHA: ec94372
Reason: push, by twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@twiss twiss mentioned this pull request Oct 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants