-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a request's destination to "webbundle" #626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a sort of a monky patch until the upstream issue, whatwg/fetch#1120, is resolved.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 19, 2021
A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 19, 2021
A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5
littledan
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making a new destination seems like a good idea to me, e.g., so that all of the content negotiation headers are sent.
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Feb 22, 2021
A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2021
A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2021
A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164}
jyasskin
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 24, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Feb 25, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 36d3a7637f9c7bc92389b8a3a43118e88aff9ca3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 25, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 36d3a7637f9c7bc92389b8a3a43118e88aff9ca3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Feb 25, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 36d3a7637f9c7bc92389b8a3a43118e88aff9ca3
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 5, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 10, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 2d21e4b74e3657723052a0bd6bf4993bf63c3572
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 10, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 8888778478581831f9f0005d3b8a388ee2f0dff9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 10, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 2d21e4b74e3657723052a0bd6bf4993bf63c3572
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 10, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 8888778478581831f9f0005d3b8a388ee2f0dff9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 10, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 2d21e4b74e3657723052a0bd6bf4993bf63c3572
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 10, 2021
…bundle" header is present, a=testonly Automatic update from web-platform-tests Add a test to check "Sec-Fetch-Dest: webbundle" header is present A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamotochromium.org> Reviewed-by: Tsuyoshi Horo <horochromium.org> Commit-Queue: Hayato Ito <hayatochromium.org> Cr-Commit-Position: refs/heads/master{#856164} -- wpt-commits: 8d3bafb23256c51e76618b849e73f960c32767ed wpt-pr: 27695 UltraBlame original commit: 8888778478581831f9f0005d3b8a388ee2f0dff9
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
A request for a bundle should have a "Sec-Fetch-Dest: webbundle" request header with the <link>-based API. This CL adds a test to make sure that the current implementation is correctly sending the header. The PR for the explainer is WICG/webpackage#626. BUG=1149816, 1168449 Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#856164} GitOrigin-RevId: b8558164a66514417f4bd37f5015feee641866a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sort of a monky patch until the upstream issue,
whatwg/fetch#1120, is resolved.