Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interface bugfix #122

Merged
merged 10 commits into from
Jul 7, 2021
Merged

Python interface bugfix #122

merged 10 commits into from
Jul 7, 2021

Conversation

rafmudaf
Copy link
Collaborator

Purpose

This pull request updates the included OpenFAST repo to add a fix for bugs in the Python interface. It should allow for WEIS to run OpenFAST simulations with output data passed back to the calling routines in-memory.

TODO:

  • Update the OpenFAST input files generated by WEIS to OpenFAST v3.0 format

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

To test whether this code works, first the OpenFAST input files generated by WEIS must be updated to OpenFAST v3.0 format. Then, I modified runFAST_pywrapper.py forcing it to use the OpenFAST Python interface.

Since I have not yet completed updating the OpenFAST input files, this has not been fully tested.

Checklist

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@rafmudaf rafmudaf marked this pull request as draft June 29, 2021 19:59
@rafmudaf rafmudaf mentioned this pull request Jun 29, 2021
12 tasks
@gbarter
Copy link
Member

gbarter commented Jun 29, 2021

@rafmudaf Thank you for this! We will get going on modifying the OpenFAST input file writers to be 3.0 compliant and also updating the existing input decks.

@rafmudaf
Copy link
Collaborator Author

No problem @gbarter. I have started to modify the input file generation routines in WEIS, and I'll continue to add it here as I work on it.

@gbarter
Copy link
Member

gbarter commented Jun 29, 2021

@ptrbortolotti is already in the midst of a big AeroelasticSE cleanup on the global_dlc_driver branch. It might be good to merge those changes into this branch first. I'll let Pietro weigh in.

@nikhar-abbas
Copy link
Collaborator

@rafmudaf Thank you for this! We will get going on modifying the OpenFAST input file writers to be 3.0 compliant and also updating the existing input decks.

If it helps out, I recently made some updates to the FAST_reader and FAST_writer in the ROSCO toolbox for OF v3.0:
NREL/ROSCO_toolbox@cdc2075

@dzalkind
Copy link
Collaborator

I just pushed some changes to run the openfast library using this test. The test failed because it's a regression test that might need to be updated. I had to mess with runFAST_pywrapper, so maybe check me there.

rafmudaf and others added 4 commits June 30, 2021 17:41
- structural control defaults in openmdao_openfast
- SimplAxCd and PtfmRef defaults in openmdao_openfast
- NBody and NBodyMod defaults in modeling schema (not supported > 1)
@gbarter
Copy link
Member

gbarter commented Jul 7, 2021

I'm not enough of a Github jockey to be able to contribute to Raf's fork to help resolve the OF 3.0 update issues. I'm going to redirect this PR into a local branch so that I can more easily contribute.

@gbarter gbarter changed the base branch from develop to update_OF July 7, 2021 17:55
@gbarter gbarter marked this pull request as ready for review July 7, 2021 21:38
@gbarter gbarter merged commit eff71b1 into WISDEM:update_OF Jul 7, 2021
@rafmudaf rafmudaf deleted the python_interface_bugfix branch July 13, 2021 20:50
dzalkind added a commit to dzalkind/WEIS that referenced this pull request Aug 10, 2022
51629665d ROSCO 2.6.0 (WISDEM#162)
77278f5d1 Flip Ct and Cq table allocation (WISDEM#129)
5d201855f Fixed wrong formatting of list items (WISDEM#122)
ad15bcdd6 ROSCO 2.5.0 (WISDEM#115)
9646dbdab Merge pull request WISDEM#90 from NREL/develop
REVERT: bd0562cd4 sigma + ipc (WISDEM#125)
REVERT: d52019231 Update docs to reflect CI process
REVERT: e9c9378e3 Merge remote-tracking branch 'upstream/develop' into develop
REVERT: 4126adbfd Bladed readthedocs (WISDEM#117)
REVERT: d7d15b044 Update version in API change docs
REVERT: 8c312875c Bladed docs (WISDEM#116)
REVERT: 5f18bf8c1 Increment version number
REVERT: 9b5499d76 ipc (WISDEM#105)
REVERT: a857211fa Allow default inputs (WISDEM#110)
REVERT: 41e0dc6e2 Fix ccrotor inputs (WISDEM#104)
REVERT: aad739652 Merge pull request WISDEM#103 from nikhar-abbas/hf/robust
REVERT: 5d5a9ba82 add bld edgewise freq to robust dict_inputs
REVERT: 93dceb7ed Break up if statement in open loop pitch (WISDEM#100)
REVERT: 6c1e4dbf1 Restart & registry (WISDEM#99)
REVERT: 50f686dd2 Open Loop Control (WISDEM#98)
REVERT: f57ee4553 Merge pull request WISDEM#97 from nikhar-abbas/b/listcheck
REVERT: 6f16a9da6 update listcheck method for numpy arrays
REVERT: aa888a1fc FOCAL Updates (WISDEM#64)

git-subtree-dir: ROSCO
git-subtree-split: 51629665d22f92770f861daeebcebd47ab32abb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants