-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interface bugfix #122
Conversation
git-subtree-dir: OpenFAST git-subtree-split: 6c3c166d73fce90b92e7f1aa63a006c6f4b2d548
For OpenFAST, this is required for the Python interface
@rafmudaf Thank you for this! We will get going on modifying the OpenFAST input file writers to be 3.0 compliant and also updating the existing input decks. |
No problem @gbarter. I have started to modify the input file generation routines in WEIS, and I'll continue to add it here as I work on it. |
@ptrbortolotti is already in the midst of a big AeroelasticSE cleanup on the global_dlc_driver branch. It might be good to merge those changes into this branch first. I'll let Pietro weigh in. |
If it helps out, I recently made some updates to the FAST_reader and FAST_writer in the ROSCO toolbox for OF v3.0: |
I just pushed some changes to run the openfast library using this test. The test failed because it's a regression test that might need to be updated. I had to mess with |
- structural control defaults in openmdao_openfast - SimplAxCd and PtfmRef defaults in openmdao_openfast - NBody and NBodyMod defaults in modeling schema (not supported > 1)
…n_interface_bugfix
I'm not enough of a Github jockey to be able to contribute to Raf's fork to help resolve the OF 3.0 update issues. I'm going to redirect this PR into a local branch so that I can more easily contribute. |
51629665d ROSCO 2.6.0 (WISDEM#162) 77278f5d1 Flip Ct and Cq table allocation (WISDEM#129) 5d201855f Fixed wrong formatting of list items (WISDEM#122) ad15bcdd6 ROSCO 2.5.0 (WISDEM#115) 9646dbdab Merge pull request WISDEM#90 from NREL/develop REVERT: bd0562cd4 sigma + ipc (WISDEM#125) REVERT: d52019231 Update docs to reflect CI process REVERT: e9c9378e3 Merge remote-tracking branch 'upstream/develop' into develop REVERT: 4126adbfd Bladed readthedocs (WISDEM#117) REVERT: d7d15b044 Update version in API change docs REVERT: 8c312875c Bladed docs (WISDEM#116) REVERT: 5f18bf8c1 Increment version number REVERT: 9b5499d76 ipc (WISDEM#105) REVERT: a857211fa Allow default inputs (WISDEM#110) REVERT: 41e0dc6e2 Fix ccrotor inputs (WISDEM#104) REVERT: aad739652 Merge pull request WISDEM#103 from nikhar-abbas/hf/robust REVERT: 5d5a9ba82 add bld edgewise freq to robust dict_inputs REVERT: 93dceb7ed Break up if statement in open loop pitch (WISDEM#100) REVERT: 6c1e4dbf1 Restart & registry (WISDEM#99) REVERT: 50f686dd2 Open Loop Control (WISDEM#98) REVERT: f57ee4553 Merge pull request WISDEM#97 from nikhar-abbas/b/listcheck REVERT: 6f16a9da6 update listcheck method for numpy arrays REVERT: aa888a1fc FOCAL Updates (WISDEM#64) git-subtree-dir: ROSCO git-subtree-split: 51629665d22f92770f861daeebcebd47ab32abb1
Purpose
This pull request updates the included OpenFAST repo to add a fix for bugs in the Python interface. It should allow for WEIS to run OpenFAST simulations with output data passed back to the calling routines in-memory.
TODO:
Type of change
Testing
To test whether this code works, first the OpenFAST input files generated by WEIS must be updated to OpenFAST v3.0 format. Then, I modified
runFAST_pywrapper.py
forcing it to use the OpenFAST Python interface.Since I have not yet completed updating the OpenFAST input files, this has not been fully tested.
Checklist