DFSM #293
Open
DFSM #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Athul, Thanks for adding this. It looks great so far. Do you need to merge in the latest ctopt? There seem to be a lot of extra changes besides the DFSM stuff. It's possible that the ctopt branch is also behind where you started this. We can discuss tomorrow. |
dzalkind
reviewed
Jul 2, 2024
dzalkind
reviewed
Jul 2, 2024
dzalkind
reviewed
Jul 2, 2024
|
|
||
| Checkout `run_simulation.py` on how to use the DFSM with ROSCO for closed-loop simulation. | ||
|
|
||
| The DFSM is available in the `dfsm_1p6.pkl` file. This model has been specifically built for simulating load cases from DLC 1.6. |
There was a problem hiding this comment.
How do we generate this pickle file? What's in the pickle file? Can it be expressed in a readable way?
dzalkind
reviewed
Jul 2, 2024
dzalkind
reviewed
Jul 2, 2024
dzalkind
reviewed
Jul 2, 2024
dzalkind
reviewed
Jul 2, 2024
dzalkind
reviewed
Jul 2, 2024
weis/dfsm/inputs/example_schema.yaml
Outdated
There was a problem hiding this comment.
Did you mean to add this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding in DFSM functionality into WEIS.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Checklist
Put an
xin the boxes that apply.