Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test/support for model_only flag #302

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add test/support for model_only flag #302

merged 1 commit into from
Jul 24, 2024

Conversation

dzalkind
Copy link
Collaborator

Purpose

Ensure that model_only flag works in WEIS. Add a test to ensure future support. Also testing modeling_overrides in script.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind
Copy link
Collaborator Author

@ptrbortolotti and @mayankchetan, I think you use this model_only feature most. Anything else we should do while we're here?

Copy link
Collaborator

@ptrbortolotti ptrbortolotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me! I also see your point of just running a 1 s simulation to make sure that the model actually runs in OpenFAST, so if this model_only flag is painful to maintain, we could also get rid of it

@dzalkind dzalkind merged commit f779fa5 into main Jul 24, 2024
36 checks passed
@dzalkind dzalkind deleted the f/model_only branch July 24, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants