Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization cleanup to fix and conform to viz changes. #305

Merged
merged 68 commits into from
Sep 18, 2024

Conversation

cfrontin
Copy link
Collaborator

@cfrontin cfrontin commented Aug 1, 2024

Purpose

Making some small bug fixes to the optimization example to conform with and unify some mutual changes from #301.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Changes to load_OMsql tested against failing log SQL files from @mayankchetan and Sora:

/projects/weis/sryu/visualization_cases/1_raft_opt/log_opt.sql
/projects/weis/sryu/visualization_cases/0_control_opt/log_opt.sql

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Collaborator Author

@cfrontin cfrontin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great- the argv call is still my go-to way of working with the OF cases fwiw

@dzalkind dzalkind merged commit 397ba52 into WISDEM:develop Sep 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants