Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix in vizFileGen and changes to handle Jul 2024 Kestrel updates #306

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

mayankchetan
Copy link
Collaborator

Purpose

Minor bug fixes for WEIS Viz input generation tool. Changes to kestrel installation script to handle the Jul 2024 Kestrel updates

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tested on Kestrel on 01AUG24

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind
Copy link
Collaborator

dzalkind commented Aug 7, 2024

Thanks @mayankchetan! When this is ready, can you assign a reviewer?

@mayankchetan
Copy link
Collaborator Author

@sora-ryu Can you review these changes?

@dzalkind, we might have to add @sora-ryu to the repo as a contributor.

@sora-ryu
Copy link
Collaborator

Hey @mayankchetan , the viz file generation works well with raft optimization, but having some error on openfast optimization. Do you want to check on this?

image

@mayankchetan
Copy link
Collaborator Author

Can you try again after updating your WEIS env? I think these are recent changes.

@sora-ryu
Copy link
Collaborator

Hmm, I am having a same error after reinstallation as well.

@sora-ryu
Copy link
Collaborator

sora-ryu commented Aug 13, 2024

@mayankchetan - I just temporarily changed modeling and geometry input yaml files for now and it works fine. (1. Manually changed the floating platform member types Ca and Cd from singular value to array type. 2. Set path2dll path as none, as it couldn't find the library)

I PRed on your repo with some minor changes that include type and default channel settings. After that, looks like ready to go.

Sora Ryu and others added 3 commits August 16, 2024 13:34
@mayankchetan
Copy link
Collaborator Author

@dzalkind, I think this is good to merge

@dzalkind dzalkind merged commit 03b0c1f into WISDEM:develop Aug 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants