Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B/no openfast #48

Merged
merged 5 commits into from
Dec 22, 2020
Merged

B/no openfast #48

merged 5 commits into from
Dec 22, 2020

Conversation

ptrbortolotti
Copy link
Collaborator

This PR:

  1. adds the analysis_settings to the modeling_options schema. These flags may eventually move away, but for now it's good to include in the schema. two of the five sub-flags were also removed as unnecessary (update_hub_nacelle and update_tower)
  2. makes sure that analysis level can only take values 1 and 2 (0 is no longer allowed)
  3. when Level3 flag is turned off, wisdem runs
  4. fixes a bug in inflow_wind initializing the ref_length for shear correctly
  5. removes some outdated warnings for inflowwind
  6. adds a column for up flow angle in the .wnd files (coherent DLCs). up flow is initialized at 0 deg (I'm checking this value) in the standards

@ptrbortolotti ptrbortolotti mentioned this pull request Dec 22, 2020
Closed
@johnjasa johnjasa merged commit 28b68c2 into develop Dec 22, 2020
@johnjasa johnjasa deleted the b/no_openfast branch December 22, 2020 17:11
nikhar-abbas added a commit to nikhar-abbas/WEIS that referenced this pull request Jun 25, 2021
@nikhar-abbas
Squashed 'ROSCO/' changes from c010d71..2a847f7
58719e5 
2a847f7 Fix compilation
f6b2cd7 Merge remote-tracking branch 'nja/develop' into develop
65b315b Merge remote-tracking branch 'upstream/main' into develop
d08ca3f Develop (WISDEM#50)
4aca5b7 increment version
1129adc trap nans in low/stopped rotor speeds
fe71ce4 Merge pull request WISDEM#49 from NREL/develop
72e7076 call shutdown routine last (WISDEM#48)
af9337b Merge pull request WISDEM#46 from dzalkind/error_catching
8f0a93c Fix controller-breaking typo
4ff5ad3 Merge remote-tracking branch 'upstream/develop' into error_catching
6729e9f Re-organize ReadSetParameters
d5963fd Remove check on F_NotchBetaNumDen(1), not necessary
398cb42 Don't check WE_CP, FA_HPFCornerFreq until API change
ce0510b Use unsaturated pitch command in setpoint smoother (WISDEM#45)
008d34a Finish making error tracing consistent
c88f272 Make error tracing consistent: RoutineNames
7fbfb86 Reorganize ROSCO file reading code
8fdeeca Read Cp surface
05879d5 Parse integer arrays
97c7bcf Parse all double arrays, only read/parse lines if no error
039389a Make Flp and Fl filter variables consistent with others Clean up parsing echo for arrays
d0fe8b1 Clean up array parsing
df32a55 Add array parsing, debug outputting, fix long string reading
22b6508 Generator power in SS (WISDEM#44)
a275d37 Fix setpoint smoother to use last gen pwr (WISDEM#43)
365d820 Merge pull request WISDEM#41 from nikhar-abbas/f/ci_tests
f928868 Add double and string input parsing
d12fbc1 Parse integer inputs, update CheckInputs
d5b7a4f Expand Assert function and rename to CheckInputs
37838fb Add error variables, error catching for interp functions
e2eab81 pr template - initial commit
9d3f2c0 mingw flag
64a754f use conda environment
05786d0 remove default shell
f20dcdb update compilers
9c523dd testing initial commit
e53ff37 Merge pull request WISDEM#39 from NREL/develop

git-subtree-dir: ROSCO
git-subtree-split: 2a847f7
ewquon added a commit to ewquon/WEIS that referenced this pull request Jul 6, 2021
@ewquon
Squashed 'ROSCO/' changes from c010d71..7e10015
9d3b7c3 
7e10015 Merge pull request WISDEM#51 from NREL/develop
2a847f7 Fix compilation
f6b2cd7 Merge remote-tracking branch 'nja/develop' into develop
65b315b Merge remote-tracking branch 'upstream/main' into develop
d08ca3f Develop (WISDEM#50)
4aca5b7 increment version
1129adc trap nans in low/stopped rotor speeds
fe71ce4 Merge pull request WISDEM#49 from NREL/develop
72e7076 call shutdown routine last (WISDEM#48)
af9337b Merge pull request WISDEM#46 from dzalkind/error_catching
8f0a93c Fix controller-breaking typo
4ff5ad3 Merge remote-tracking branch 'upstream/develop' into error_catching
6729e9f Re-organize ReadSetParameters
d5963fd Remove check on F_NotchBetaNumDen(1), not necessary
398cb42 Don't check WE_CP, FA_HPFCornerFreq until API change
ce0510b Use unsaturated pitch command in setpoint smoother (WISDEM#45)
008d34a Finish making error tracing consistent
c88f272 Make error tracing consistent: RoutineNames
7fbfb86 Reorganize ROSCO file reading code
8fdeeca Read Cp surface
05879d5 Parse integer arrays
97c7bcf Parse all double arrays, only read/parse lines if no error
039389a Make Flp and Fl filter variables consistent with others Clean up parsing echo for arrays
d0fe8b1 Clean up array parsing
df32a55 Add array parsing, debug outputting, fix long string reading
22b6508 Generator power in SS (WISDEM#44)
a275d37 Fix setpoint smoother to use last gen pwr (WISDEM#43)
365d820 Merge pull request WISDEM#41 from nikhar-abbas/f/ci_tests
f928868 Add double and string input parsing
d12fbc1 Parse integer inputs, update CheckInputs
d5b7a4f Expand Assert function and rename to CheckInputs
37838fb Add error variables, error catching for interp functions
e2eab81 pr template - initial commit
9d3f2c0 mingw flag
64a754f use conda environment
05786d0 remove default shell
f20dcdb update compilers
9c523dd testing initial commit
e53ff37 Merge pull request WISDEM#39 from NREL/develop

git-subtree-dir: ROSCO
git-subtree-split: 7e100154bb8fad0fa10e7bca826d7ee1b68192b1
dzalkind pushed a commit to dzalkind/WEIS that referenced this pull request Sep 14, 2021
@nikhar-abbas
call shutdown routine last (WISDEM#48)
72e7076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjasa johnjasa johnjasa approved these changes

@gbarter gbarter gbarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptrbortolotti @johnjasa @gbarter