Update kixcode to adhere to PostNL standards. #124
Conversation
|
I would say the kixcode should be a property on the model and should not be created in the export. If the current export functionality does not support that, maybe it should be a separate function? |
svenvanhal
force-pushed
the
bugfix-123
branch
from
f5200d2 to
216d61f
Compare
svenvanhal
force-pushed
the
bugfix-123
branch
from
216d61f to
29abc52
Compare
|
The new property is not used in export yet? |
|
I just tried to use the property in the current export... I have no clue how it would work :') |
|
@praseodym @jgadelange Me neither, but since the new export functionality is long overdue, I wouldn't put too much time in patching the old one. |
|
Then I think it would be best for now to also add it in the old export the way you did before. |
|
This is a PR from 2015. Is this still relevant? |
|
Don't know. Do we still print kix-codes on our outgoing mail? |
|
That we still do! But it seems to work fine 🙃 |
|
I am closing this issue since no problems have occurred with kixcodes for the past few years. |
Fixes #123.