Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/transpiling issues #439

Closed
wants to merge 5 commits into from

Conversation

andrewmclagan
Copy link

This PR addresses outstanding issues for Edge and IE11: #438 AND #426

The core of this PR builds a es version of the package to consume in webpack, rollup or similar bundlers. Oddly this package does not actually transpile anything apart from a UMD build for old browsers. This still works for most browsers as the default CJS module exported by package.json actually only uses the spread operator that is supported in most major browsers aside from IE and Edge.

Not sure how this has not been picked up before.

@andrewmclagan andrewmclagan changed the base branch from master to v1 September 19, 2019 09:37
@andrewmclagan
Copy link
Author

As an aside i will make some comments that may or may not be appropriate :-)

  • Rollup would be better suited as this is a library and Webpack is more suited for bundling apps.
  • The .eslint config is perhaps the oddest I have yet come across? What standard is this and why? makes it hard to work with as a common js dev.
  • folder structure could follow a few standards that we now have e.g. /src, /build, /dist etc..

OTHERWISE wow great little library we use this allot. Only we have allot of clients complaining on Edge...

@andrewmclagan
Copy link
Author

Actually close this. This library needs ALLOT of work before its going to be usable in a webpack environment...

@andrewmclagan
Copy link
Author

If the author is happy to accept PRs I will write one up, until then its too much time to commit without knowing if it will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant