Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Largo Explore Related Widget breaks Slideshows in posts with categories. #1240

Closed
benlk opened this issue Jun 24, 2016 · 4 comments
Closed
Labels
priority: normal Must be completed before release of this version of plugin. type: bug

Comments

@benlk
Copy link
Collaborator

benlk commented Jun 24, 2016

Javascript console in the browser fails thusly:

Uncaught Error: Syntax error, unrecognized expression: a[href^=#]

Where does Largo have that?

js/jquery.idTabs.js:110: 
js/jquery.idTabs.js:212: 
js/jquery.idTabs.js:213: 

Does the affected site's child theme have that syntax? No.

Does removing the category and tags prevent that from appearing? Yes.

Does it happen only with tags? That error is not there with tags.

Does it happen only with categories? With categories but no tags, it happens.

What's the difference between those two pages? The old-style largo-explore-related-widget loads when a post has categories. That widget uses tabs.

@benlk
Copy link
Collaborator Author

benlk commented Jun 27, 2016

List of affected site IDs is at the bottom of this list: INN/wp-scripts#5

  • Temporary-temporary solution: Replace that widget on the affected sites.
  • future solution:
    • remove widget
    • remove idTabs.js
    • remove styles for above

@benlk benlk added priority: normal Must be completed before release of this version of plugin. type: pre-launch todo and removed type: pre-launch todo labels Jun 27, 2016
@aschweigert
Copy link

see #1241

@benlk benlk closed this as completed Jun 27, 2016
@benlk benlk added status: wontfix and removed priority: normal Must be completed before release of this version of plugin. labels Jun 27, 2016
@benlk benlk reopened this Jun 27, 2016
@benlk benlk added priority: normal Must be completed before release of this version of plugin. and removed status: wontfix labels Jun 27, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Sep 30, 2016
@benlk
Copy link
Collaborator Author

benlk commented Sep 30, 2016

Adding this here to make it more findable: #rp0 #rp1 jquery.js?ver=1.12.4:2 Uncaught Error: Syntax error, unrecognized expression: a[href=#rp0]:first

And this will be closed with 0.5.5.

@benlk
Copy link
Collaborator Author

benlk commented Oct 20, 2016

#1241 merged; I'm closing this.

@benlk benlk closed this as completed Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Development

No branches or pull requests

2 participants