Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explore related widget #1241

Merged
merged 4 commits into from
Sep 7, 2016
Merged

Conversation

aschweigert
Copy link

@aschweigert aschweigert commented Jun 27, 2016

This should have been deprecated already and I'm not particularly worried about explicitly covering this with an update script since so few sites are affected and we've already manually updated our sites. Anywhere else in Largo we'd need to lose this to remove it once and for all?

@benlk
Copy link
Collaborator

benlk commented Jun 27, 2016

  • remove widget
  • remove idTabs.js
  • remove styles for above

@aschweigert
Copy link
Author

@benlk those things are all included in this PR, just wondering about anything else?

@benlk
Copy link
Collaborator

benlk commented Jun 27, 2016

Yeah, sorry, I misread this as an issue and not as a PR, and copied some stuff over.

There's a test in the update tests that needs to be updated, to remove a reference to this widget:

tests/inc/test-update.php:141:           $this->assertEquals('largo-explore-related-widget-2', $widgets['article-bottom'][4]);

Translation files mention this plugin, but those can be rebuilt at a later date (before releasing the next version of Largo) because they're prone to merge conflicts and are terrible.

@aschweigert
Copy link
Author

@benlk can you resolve any conflicts with develop so we can review and merge this? anything else that's still needed here?

@benlk
Copy link
Collaborator

benlk commented Sep 2, 2016

Nope, updating it with the latest develop and updating a test was it. There's some CSS conflicts, which are what affect mergeability.

The other failing tests are the ones that should be addressed in #1188

@benlk benlk assigned rclations and unassigned benlk Sep 3, 2016
@rclations
Copy link

looks good to me

@rclations rclations merged commit 5900d73 into develop Sep 7, 2016
@aschweigert aschweigert deleted the remove-explore-related-widget branch September 21, 2016 01:01
benlk added a commit that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants