-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explore related widget #1241
Conversation
|
@benlk those things are all included in this PR, just wondering about anything else? |
Yeah, sorry, I misread this as an issue and not as a PR, and copied some stuff over. There's a test in the update tests that needs to be updated, to remove a reference to this widget:
Translation files mention this plugin, but those can be rebuilt at a later date (before releasing the next version of Largo) because they're prone to merge conflicts and are terrible. |
@benlk can you resolve any conflicts with develop so we can review and merge this? anything else that's still needed here? |
Nope, updating it with the latest develop and updating a test was it. There's some CSS conflicts, which are what affect mergeability. The other failing tests are the ones that should be addressed in #1188 |
looks good to me |
This should have been deprecated already and I'm not particularly worried about explicitly covering this with an update script since so few sites are affected and we've already manually updated our sites. Anywhere else in Largo we'd need to lose this to remove it once and for all?