-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go through theme and make list of all places where "TODO" "TO DO" and "XXX" appear #963
Comments
I'd like to take this on! Assuming I'm understanding it right, of course. Go through files in the |
Instead of adding the notes as a file in the branch, could you just leave them in a response to this ticket? That would work best with our workflow. There's also probably a few comments like this that aren't tagged with the marks listed above, which would make them harder to find. If you run across any of those, filing a pull request that adds Thanks for your help! |
Sure thing! I didn't wanna start writing down these note locations in the wrong and then have you guys be like "nah, that's not what we're after". I can definitely do that, thanks for letting me know! 😄 |
First chunk down! Here we go: |
I'd say that https://github.com/yayannabelle/Largo/blob/develop/inc/post-templates.php#L126 does deserve an @todo. Thanks for the PR, and your work here. How would you like to be credited in the 0.5.5 release notes? |
No worries - still got a few more folders to get through, apologies for the delay! Annabelle W / @yayannabelle would be just fine, thanks! |
Second and last lot: Files I've added tentative "@todo ?"s to: first, second, third, and fourth. And that's all the files checked! Time for a 2nd PR. Please let me know if there's anything else of this kind that needs doing in the future, I'd be more than happy to help! |
A lot of older Largo files have notes to future developers, but these notes and issues aren't captured anywhere.
Common marks for these notes are:
When conducting this review, use the
develop
branch.The text was updated successfully, but these errors were encountered: