Final @TODOs added (4 total). #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, thanks @yayannabelle! |
benlk
reviewed
Oct 11, 2016
| $template = get_stylesheet_directory() . "/{$custom_field}"; | ||
| } else if ( file_exists( get_template_directory() . "/{$custom_field}") ) { | ||
| $template = get_template_directory() . "/{$custom_field}"; | ||
| if ( file_exists( get_stylesheet_directory() . '/{$custom_field}' ) ) { |
There was a problem hiding this comment.
@aschweigert Can we check that this works? I think that switching to single quotes here breaks the curly-braces interpretation: https://secure.php.net/manual/en/language.operators.string.php#110937
There was a problem hiding this comment.
Tests failed to run because the branch was deleted before tests could be run: https://travis-ci.org/INN/Largo/builds/166745124
There was a problem hiding this comment.
not sure why we're using curly braces here but that's for another day, i suppose
aschweigert
added a commit
that referenced
this pull request
Oct 11, 2016
|
👍 |
|
My pleasure, glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to issue #963.