forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job title to fields accepted by coauthors #1098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlk
added
the
priority: high
Either blocks work on a priority-normal task or a solution here informs other work.
label
Jan 26, 2016
This is a PR against master, because in discussions on #1097 it was determined that:
|
…or-bio-description, defaulting to hide. Affects both normal users and Co-Authors Plus guest authors.
Additional changes (updated after 55a7a7b below):
A normal user in default Largo: A guest author on theme-wenews: |
After merging this, make sure to add these changes to the theme-wenews and theme-invw byline function. |
…als/author-bio-description, defaulting to hide." We decided that this would be better and more-simply done with a site-wide option to disable display of bylines, defaulting to disable This reverts commit ad85b51.
…phis, for normal users and for coauthors.
…s. This matches Adam's suggestion. Also: Move the job title outside the link for coauthors, to match the behavior when Co-Authors Plus is not enabled.
benlk
added a commit
that referenced
this pull request
Jan 26, 2016
Add job title to fields accepted by coauthors
benlk
added a commit
that referenced
this pull request
Jan 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: high
Either blocks work on a priority-normal task or a solution here informs other work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
largo_byline
if Co-Authors Plus is enabledlargo_byline
if Co-Authors Plus is not enabledlargo_author_link
partials/author-bio-social-links.php
respect the coauthors option. This will only affect coauthors users. This does not affect normal users; their email addresses will still display.Why
For #1097 and WE-72.