Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'this author' instead of any other reference in the author bio read-more link #1112

Merged
merged 2 commits into from
Jan 29, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 29, 2016

Changes

  • Uses 'this author' if the author's first name is not available.

screen shot 2016-01-28 at 7 16 16 pm

## Why

This button wasn't always displaying a username, because not all users set their "first name" field in the WordPress user settings.

For http://jira.inn.org/browse/WE-86

@aschweigert
Copy link

I would keep the "More by Firstname" as the default but just add this as a fallback (if the firstname doesn't exist)

aschweigert added a commit that referenced this pull request Jan 29, 2016
Use 'this author' instead of any other reference in the author bio read-more link
@aschweigert aschweigert merged commit a0dc518 into master Jan 29, 2016
@aschweigert aschweigert deleted the WE-86-more-by-this-author branch January 29, 2016 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants