Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor social media widgets #1115

Merged
merged 17 commits into from
Sep 21, 2016
Merged

refactor social media widgets #1115

merged 17 commits into from
Sep 21, 2016

Conversation

aschweigert
Copy link

still to do:

  • add a filter to the largo follow widget to allow sites to add additional networks/links from a child theme
  • try to figure out why these brand colors/styles exist in the largo-follow.less and in single.less (seems wrong)
  • bleh, looks like some of those fb responsive styles are also needed, just not for this widget

Sorry, something went wrong.

@aschweigert aschweigert self-assigned this Jan 30, 2016
@aschweigert
Copy link
Author

nm, fb widget code was just way out of date

@aschweigert aschweigert changed the title refactor largo follow widget refactor social media widgets Jan 30, 2016
@aschweigert
Copy link
Author

aschweigert commented Jan 31, 2016

almost there, would still like to:

  • update the twitter widget
  • apply the same filter (largo_additional_networks) to the output of social icons in the header and footer

Sorry, something went wrong.

@aschweigert
Copy link
Author

this will also eventually address #219

@aschweigert
Copy link
Author

@jackbrighton you said as far as you could tell the twitter widget just needs the widget ID, right? none of the other parameters for the various widget types make a difference anymore?

@jackbrighton
Copy link

Yeah but that was a month ago or so while handling a related ticket and doing lot of other stuff. I'd like to quickly verify before we strip out code.

@aschweigert
Copy link
Author

ok. no worries, just wanted to further test that hypothesis and make any necessary changes as we address this PR. found out, for example that the version of the fb like box we were using was no longer supported (hadn't been for over a year :(

@aschweigert
Copy link
Author

@jackbrighton fyi re: the twitter widget, it's true that the text/url are not strictly necessary, but they are used as a fallback if the widget js doesn't load so it's probably worth keeping them

@jackbrighton
Copy link

Thanks, that's good to know!

Sent from my iPhone

On Feb 28, 2016, at 12:47 PM, Adam Schweigert notifications@github.com wrote:

@jackbrighton fyi re: the twitter widget, it's true that the text/url are not strictly necessary, but they are used as a fallback if the widget js doesn't load so it's probably worth keeping them


Reply to this email directly or view it on GitHub.

@aschweigert
Copy link
Author

Just a note that Twitter search widgets appear to be dead now. Probably a minor issue, but that's a thing.

@aschweigert
Copy link
Author

This is good to go. We may at some point want to make it easier to add additional social networks to the regular theme options page but punting on that now. For a sample implementation of how to add a new social network to show in the follow widget and the row of icons in the header/footer, see: https://bitbucket.org/projectlargo/theme-gijn/src/cd95b21eb2bfc7ab2d338eaff1d5a9d1ff0149f4/inc/options.php?at=master&fileviewer=file-view-default

Note that you also need some CSS for whichever button you're adding if the icon you want is not included in our current fontello set.

@rclations rclations merged commit 3e9b3ff into develop Sep 21, 2016
@aschweigert aschweigert deleted the refactor-follow-widget branch September 21, 2016 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants