Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get current user to wp get current user #1247

Conversation

MsPseudolus
Copy link

Fixes "Required" item listed in issue #844 get_currentuserinfo() found in the file users.php. Deprecated since version 4.5. Use wp_get_current_user() instead. Line 144"

Checks that current WP version is 4.5 or higher only uses wp_get_current_user() if true, otherwise still uses get_currentuserinfo().

Performed a diff of the var_dump of both get_currentuserinfo() and wp_get_current_user(), and they're identical (as expected).

@MsPseudolus
Copy link
Author

Hey, y'all. I'm not understanding why that test is failing (per Travis) on this and my other PR, so I'll chill on PR's 'til I do :-D Thanks for your patience with me!

@benlk
Copy link
Collaborator

benlk commented Jul 14, 2016

This test is failing because of #1233, which is already fixed in the development branch of Largo. It's not an important one.

Looks good to me.

@MsPseudolus
Copy link
Author

Thanks, Ben! Would it be better if I work in the develop branch? Or is it easier for little stuff like this to go to master?

@benlk
Copy link
Collaborator

benlk commented Jul 15, 2016

Something this small is fine in master, but please file any future large stuff against develop.

@aschweigert aschweigert added this to the hotfix milestone Jul 18, 2016
@aschweigert aschweigert assigned benlk and unassigned aschweigert Jul 18, 2016
@benlk benlk merged commit 81b4c25 into WPBuddy:master Jul 18, 2016
@MsPseudolus MsPseudolus deleted the update-get_current_user-to-wp_get_current_user branch July 18, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants