don't display the sticky nav at the top of the page unless it's appropriate #1266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
stickyNavScrollTopHide
on theNavigation
prototype injs/navigation.js
that removes theshow
class if the window is scrolled too far up.Navigation.prototype.stickyNavResizeCallback
. The new case groupings are:$(window).width() <= 768
, where the sticky nav should initiallyshow
at all scroll positions.Largo.sticky_nav_options.sticky_nav_display || ( Largo.sticky_nav_options.main_nav_hide_article && ($('body').hasClass('single') || $('body').hasClass('page')) )
, where the sticky nav should notshow
if the scrollTop is above the main nav.show
.Navigation.prototype.stickyNavScrollCallback
, prevent theshow
class from being added to the sticky nav if the page was not previously scrolled. This is needed becauseNavigation.prototype.stickyNavScrollCallback
is called onNavigation.prototype.bindStickyNavEvents is called on
Navigation.prototype.bindEventsis called on
Navigation.prototype.init` is called when the page is loaded.Why
After #1262, the sticky nav appears at the top of the page on initial page load, when it should not appear until farther down the page (after scrolling past the main nav). This is part of #1260.
Notes
This PR adds some in-file docs for changes made in
js/navigation.js
in this PR, but the file in general needs a lot more documentation. Even something like this would be helpful in the future: