Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Sharing: Move mailto functionality from js to html #1281

Merged
merged 2 commits into from
Aug 30, 2016
Merged

Social Sharing: Move mailto functionality from js to html #1281

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a876c45
move mailto functionality into html instead of js
rclations Aug 30, 2016
eba9e60
updating textdomain
rclations Aug 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion inc/post-social.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ function largo_post_social_links( $echo = true ) {
}

if ( $utilities['email'] === '1' ) {
$output .= '<span data-service="email" class="email custom-share-button share-button"><a><i class="icon-mail"></i> <span class="hidden-phone">' . esc_attr( __( 'Email', 'largo' ) ) . '</span></a></span>';
$output .= sprintf(
'<span data-service="email" class="email share-button"><a href="mailto:?subject=%2$s&body=%3$s%0D%0A%4$s" target="_blank"><i class="icon-mail-alt"></i> <span class="hidden-phone">%1$s</span></a></span>',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick note on this -

The body field still opens in Apple Mail with the post URL appended to the end of the excerpt (no space in-between), but I don't believe there's any way around this.

We could add a <br /> tag, but that's not the correct way to do that, and it would likely have mixed results in browser-driven email applications.

For more info, see http://stackoverflow.com/questions/22765834/insert-a-line-break-in-mailto-body#22765878

esc_attr( __( 'Email', 'npr' ) ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't edit your fork but need to use the largo textdomain here instead of npr

rawurlencode( html_entity_decode( get_the_title(), ENT_QUOTES, "UTF-8" ) ), // subject
rawurlencode( html_entity_decode( strip_tags( get_the_excerpt() ), ENT_QUOTES, "UTF-8" ) ), // description
rawurlencode( html_entity_decode( get_the_permalink() ) ) // url
);
}


Expand Down
13 changes: 0 additions & 13 deletions js/largoCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,6 @@ jQuery(document).ready(function($) {
});
},

// Handle the email service
do_email: function( data ) {
var url = 'mailto:?' + $.param({
subject: data.title,
body: data.description + "\n" + data.url
});

this.popup({
url: url,
name: 'email_share'
});
},

// Handle the Google+ service
do_googleplus: function( data ) {
var url = 'https://plus.google.com/share?' + $.param({
Expand Down
2 changes: 1 addition & 1 deletion js/largoCore.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.