Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the sticky nav overflow menu to something that doesn't conflict with menus named 'More' #1339

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 11, 2016

Changes

  • The HTML id for the overflow menu in the sticky nav is now #sticky-nav-overflow

Why

From #1336:

If the name of the Global Navigation menu slugifies to "more", then the slug of the menu name causes a conflict somehow. Changing the name of the identifier for the overflow menu when we create it in navigation.js fixes the problem, and because it's contained all within one file, can be deployed without worrying about cache conflicts between Javascript and PHP.

@benlk benlk added type: bug priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: needs review labels Oct 11, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 11, 2016
@aschweigert aschweigert merged commit f6b0886 into develop Oct 11, 2016
@aschweigert aschweigert deleted the 1336-fix-overflow-menu-when-named-More branch October 11, 2016 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: needs review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants