Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show the publish date in largo_byline() output; move updated date atop the post content #1343

Merged
merged 10 commits into from
Oct 12, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 11, 2016

Changes

  • in Largo_Byline class and its extenders, remove the case where the post edited time would show
  • create new function largo_edited_date() to show the edited date for a post, and allow it to be used outside The Loop
  • create action largo_after_hero_largo_edited_date hooked on largo_after_hero that outputs largo_edited_date() wrapped in a div.entry-content.clearfix
  • stubbed tests.

Here's how it looks in Largo, and how it interacts with something else hooked on largo_after_hero:

screen shot 2016-10-11 at 3 30 12 pm

Adopting child theme styles on the site that requested this:

screen shot 2016-10-11 at 3 41 51 pm

For #1341

@benlk benlk added priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: feature request status: needs review labels Oct 11, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 11, 2016
@aschweigert
Copy link

i think we'll probably want some better default styles here (for the updated date/time) but otherwise this looks good to me, passing off to @Julia67 for a look at the default styles

@aschweigert aschweigert merged commit dc07a32 into develop Oct 12, 2016
@aschweigert aschweigert deleted the 1341-Largo_Byline-only-show-publish-date branch October 12, 2016 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: needs review type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants