Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document minimum PHP version for Largo #1345

Merged
merged 5 commits into from
Oct 12, 2016
Merged

Document minimum PHP version for Largo #1345

merged 5 commits into from
Oct 12, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 12, 2016 •
edited
Loading

Changes

  • Notes minimum PHP version at https://largo.readthedocs.io/users/download.html
  • Directs users to the tagged releases first, then to the master branch
  • Notes minimum WordPress version in readme.md, but not in the user docs because the user docs kinda assume that you're going to be installing the latest version. The Version used here is 4.1 because that's the earliest version that the develop branch tests against at this time.

For #1344. This is a PR against master because it needs to affect largo.readthedocs.io, which only compiles from the master branch.

@benlk benlk added priority: normal Must be completed before release of this version of plugin. status: needs review labels Oct 12, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 12, 2016
@aschweigert aschweigert merged commit 2856790 into master Oct 12, 2016
@aschweigert aschweigert deleted the 1344-document-minimum-php-version branch October 12, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aschweigert aschweigert

@jackbrighton jackbrighton

Labels
priority: normal Must be completed before release of this version of plugin. status: needs review
Projects
None yet
Milestone
0.5.5 - Story Elements
Development

Successfully merging this pull request may close these issues.
3 participants
@benlk @aschweigert @jackbrighton