[Feature] Operative UI Style #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request introduces new entries and configurations for the HUD theme in both English and Russian locales, enhancing the user interface customization options. Specifically, it adds the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (45)
Resources/Textures/_White/Interface/Operative/SlotBackground.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/back.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/belt.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/ears.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/ears_extra.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/glasses.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/gloves.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/hand_l.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/hand_l_no_letter.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/hand_r.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/hand_r_no_letter.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/head.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/id.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/mask.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/neck.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/pocket.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/shoes.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/socks.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/suit.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/suit_storage.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/toggle-alt.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/toggle.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/underwearb.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/underweart.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/uniform.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/web.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Slots/wrists.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_bottom.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_bottomLeft.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_bottomRight.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_center.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_left.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_right.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_top.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_topLeft.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/piece_topRight.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/sidebar_bottom.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/sidebar_mid.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/sidebar_top.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/tile_blocked.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/tile_blocked_opaque.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/tile_empty.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/Storage/tile_empty_opaque.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/slot_highlight.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Operative/template_small.pngis excluded by!**/*.png
📒 Files selected for processing (4)
- Resources/Locale/en-US/_white/escape-menu/ui/options.ftl (1 hunks)
- Resources/Locale/ru-RU/_white/escape-menu/ui/options.ftl (1 hunks)
- Resources/Prototypes/_White/hud.yml (1 hunks)
- Resources/Prototypes/_White/themes.yml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
- Resources/Locale/en-US/_white/escape-menu/ui/options.ftl
- Resources/Locale/ru-RU/_white/escape-menu/ui/options.ftl
🔇 Additional comments (3)
Resources/Prototypes/_White/hud.yml (1)
5-5: Verify theme ordering.The order value of 7 suggests this theme will be displayed after other themes in the UI. Please ensure this ordering aligns with the intended position in the theme selection dropdown.
Let's check other theme orders to confirm proper positioning:
✅ Verification successful
Order value 7 is correctly positioned as the last theme in sequence
Based on the search results, the theme ordering is consistent:
- Minimalist (order: 1)
- Slimecore (order: 2)
- Plasmafire (order: 3)
- Clockwork (order: 4)
- Ashen (order: 5)
- Retro (order: 6)
- Operative (order: 7)
The order value of 7 for the Operative theme appropriately places it as the last item in the theme selection dropdown.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check ordering of all HUD themes # Test: Extract all hudTheme entries with their order values rg -U "type: hudTheme\n.*\n.*\n.*\n.*order: \d+" --multilineLength of output: 1892
Resources/Prototypes/_White/themes.yml (2)
1-3: LGTM! Theme configuration follows the standard format.The theme configuration is well-structured with proper type definition, unique identifier, and correct resource path format.
5-14: Verify color contrast ratios for accessibility.While the color choices appear intentional, it's important to ensure they meet WCAG accessibility guidelines for contrast ratios, particularly for text colors:
whiteText: "#FFF5EE"should have sufficient contrast against background colorsslotText: "#333850"might need verification againstslotColor: "#0f1215"
Remuchi
approved these changes
Oct 27, 2024
This was referenced Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Sigma UI style
Медиа
Содержание
(у меня монитор не вмещает 100% масштаб)
Изменения
🆑 PuroSlavKing