[Fix] Butletron / Бутлетрон #105
Conversation
WalkthroughThe changes involve the addition of a new Changes
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Resources/Prototypes/DeltaV/NPC/roboisseur.yml (1)
44-44: Add newline at end of file.Add a newline character at the end of the file to comply with YAML best practices.
# WD EDIT END +🧰 Tools
🪛 yamllint
[error] 44-44: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- Resources/Prototypes/DeltaV/NPC/roboisseur.yml (1 hunks)
🧰 Additional context used
🪛 yamllint
Resources/Prototypes/DeltaV/NPC/roboisseur.yml
[error] 44-44: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
Resources/Prototypes/DeltaV/NPC/roboisseur.yml (1)
31-43: Verify collision box size and density values.The addition of the Fixtures component is a good solution for fixing collision issues. However, please verify:
- Is the collision box size (0.3x0.3 units) sufficient to cover the entire sprite?
- Is the density value of 60 appropriate for this type of structure?
Let's check other similar entities for comparison:
✅ Verification successful
Based on the extensive search results showing fixtures configurations across the codebase, I can now make an informed assessment about the collision box size and density values for the Butletron character.
Collision box and density values are appropriate for this type of entity
The current configuration:
- Box size: 0.3x0.3 units (-0.15 to 0.15 in both dimensions)
- Density: 60
- Mask: MachineMask
- Layer: MidImpassable, LowImpassable
This aligns well with similar entities in the codebase:
- Most stationary machines use box sizes between 0.25-0.45 units
- The density value of 60 matches the base_structure.yml template which many machines inherit
- The MachineMask and MidImpassable/LowImpassable layers are standard for machine-type entities
The values are particularly consistent with:
- Other NPCs/robots with similar roles (density 50-80)
- Stationary service machines (box size 0.25-0.35)
- Base structure template (density 60)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other entities with Fixtures components to compare values rg -U "type: Fixtures" -A 10 "Resources/Prototypes"Length of output: 408145
# Description Fixes Butlertron's hitbox. Thanks to WWhiteDreamProject/wwdpublic#105 # Changelog :cl: - fix: Butlertron is no longer as wide as a barn. --------- Co-authored-by: Spatison <137375981+Spatison@users.noreply.github.com>
# Description Fixes Butlertron's hitbox. Thanks to #105 # Changelog :cl: - fix: Butlertron is no longer as wide as a barn. --------- Co-authored-by: Spatison <137375981+Spatison@users.noreply.github.com> (cherry picked from commit c90972449df39f808c3d5088613e62c87d4df74d)
Описание PR
Уменьшена колизия у Бутлетрона
Изменения
🆑 Spatison