[Tweak] Fire Alarm Sound

[PuroSlavKing]

Описание PR

Я не мог не насрать, это было слишком хорошо.

---

Медиа

Список

ВНИМАНИЕ ПОЖАРНАЯ ТРЕВОГА, СРОЧНО ПОКИНЬТЕ ПОМЕЩЕНИЕ!! 🔊 🔥

FireAlarm.mp4

---

Изменения

🆑 PuroSlavKing

• tweak: Измененён звук пожарной тревоги.

[coderabbitai]

Walkthrough

The changes in this pull request involve updating the AlarmSound property in the AtmosAlarmableComponent class located in the Content.Server.Atmos.Monitor.Components namespace. The sound file path for the alarm notification has been changed from "/Audio/Machines/alarm.ogg" to "/Audio/_White/Machines/fire_alarm.ogg". This modification solely affects the audio asset used for alarm notifications without altering any other components of the class.

Changes

File Path	Change Summary
Content.Server/Atmos/Monitor/Components/AtmosAlarmableComponent.cs	Updated AlarmSound property from "/Audio/Machines/alarm.ogg" to "/Audio/_White/Machines/fire_alarm.ogg"

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

Content.Server/Atmos/Monitor/Components/AtmosAlarmableComponent.cs (1)

39-39: Consider following standard asset directory structure.

The path /Audio/_White/Machines/fire_alarm.ogg uses a non-standard directory prefix _White. Consider moving the file to the standard /Audio/Machines/ directory to maintain consistency with the project's asset organization.

-    public SoundSpecifier AlarmSound { get; set; } = new SoundPathSpecifier("/Audio/_White/Machines/fire_alarm.ogg");
+    public SoundSpecifier AlarmSound { get; set; } = new SoundPathSpecifier("/Audio/Machines/fire_alarm.ogg");

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6093d72 and 77df11d.

⛔ Files ignored due to path filters (1)

• Resources/Audio/_White/Machines/fire_alarm.ogg is excluded by !**/*.ogg

📒 Files selected for processing (1)

• Content.Server/Atmos/Monitor/Components/AtmosAlarmableComponent.cs (1 hunks)

🔇 Additional comments (2)

Content.Server/Atmos/Monitor/Components/AtmosAlarmableComponent.cs (2)

39-39: Verify volume settings with the new sound file.

The alarm volume is set to -10. Since you're changing the sound file, please test if this volume setting is appropriate for the new fire alarm sound to ensure it's neither too loud nor too quiet.

Also applies to: 41-42

---

39-39: Verify the existence of the new sound file.

The sound file path has been updated to use a custom directory. Please ensure that the file /Audio/_White/Machines/fire_alarm.ogg exists in the project's assets.

✅ Verification successful

Sound file path verified successfully

The new sound file /Audio/_White/Machines/fire_alarm.ogg exists at the correct location in the Resources directory.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the new sound file exists
# Expected: The file should exist in the resources/audio directory

fd -e ogg "fire_alarm.ogg" 

Length of output: 73

[PuroSlavKing]

реально мёрдж