Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UbratHalloweenIzRuk #119

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Gersoon458
Copy link
Contributor

Описание PR

Убрать корзинку и подарок из рук, чтоб не ебало тесты чере 1-2 дня


Изменения

🆑

  • remove: Fun removed :( Specifically the basket and the gift from the hands :(/Удалено веселье :( А конкретно корзинка и подарок из рук :(

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Walkthrough

The changes across multiple YAML configuration files primarily involve updates to various job definitions and their associated starting gear. Key modifications include the removal of inhand items such as CandyBucket and PresentHalloweenRandom, adjustments to access permissions, and refinements in job requirements, including departmental affiliations and playtime requirements. Several roles have also seen the addition of new components or special abilities, enhancing their functionality within the game. Overall, the changes reflect a restructuring of job roles and starting gear specifications.

Changes

File Path Change Summary
Resources/Prototypes/Roles/Jobs/Cargo/cargo_technician.yml Updated CargoTechnician job configuration; added CargoPDA to startingGear, removed inhand items.
Resources/Prototypes/Roles/Jobs/Cargo/quartermaster.yml Modified Quartermaster job requirements and access; detailed startingGear, removed inhand items.
Resources/Prototypes/Roles/Jobs/Cargo/salvage_specialist.yml Changed SalvageSpecialist department from Cargo to Logistics; removed inhand items.
Resources/Prototypes/Roles/Jobs/Civilian/assistant.yml Removed Passenger job definition and associated inhand items from PassengerGear.
Resources/Prototypes/Roles/Jobs/Civilian/bartender.yml Removed inhand items from BartenderGear.
Resources/Prototypes/Roles/Jobs/Civilian/botanist.yml Removed inhand items from BotanistGear, adjusted access formatting.
Resources/Prototypes/Roles/Jobs/Civilian/chaplain.yml Updated Chaplain role with new requirements and abilities; removed inhand items.
Resources/Prototypes/Roles/Jobs/Civilian/chef.yml Added ProfessionalChef component; removed inhand items from ChefGear.
Resources/Prototypes/Roles/Jobs/Civilian/clown.yml Updated access and special abilities; removed inhand items from ClownGear.
Resources/Prototypes/Roles/Jobs/Civilian/janitor.yml Introduced JanitorMaidGear, removed inhand items from both JanitorGear and JanitorMaidGear.
Resources/Prototypes/Roles/Jobs/Civilian/lawyer.yml Updated supervisor designation and modified starting gear items.
Resources/Prototypes/Roles/Jobs/Civilian/librarian.yml Updated job requirements and removed inhand items from LibrarianGear.
Resources/Prototypes/Roles/Jobs/Civilian/mime.yml Added access level and special components; removed inhand items from MimeGear.
Resources/Prototypes/Roles/Jobs/Civilian/musician.yml Updated access permissions and removed inhand items from MusicianGear.
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.yml Added innerClothingSkirt to starting gear; removed inhand items.
Resources/Prototypes/Roles/Jobs/Command/captain.yml Updated department names; removed inhand items from CaptainGear.
Resources/Prototypes/Roles/Jobs/Command/centcom_official.yml Removed inhand items from CentcomGear.
Resources/Prototypes/Roles/Jobs/Command/head_of_personnel.yml Adjusted access permissions and removed inhand items from HoPGear.
Resources/Prototypes/Roles/Jobs/Engineering/atmospheric_technician.yml Removed inhand items from AtmosphericTechnicianGear.
Resources/Prototypes/Roles/Jobs/Engineering/chief_engineer.yml Removed commented-out requirements and inhand items from ChiefEngineerGear.
Resources/Prototypes/Roles/Jobs/Engineering/senior_engineer.yml Disabled role selection preference; removed inhand items from SeniorEngineerGear.
Resources/Prototypes/Roles/Jobs/Engineering/station_engineer.yml Added antagAdvantage; removed inhand items from StationEngineerGear.
Resources/Prototypes/Roles/Jobs/Engineering/technical_assistant.yml Updated requirements; removed inhand items from TechnicalAssistantGear.
Resources/Prototypes/Roles/Jobs/Medical/chemist.yml Updated job requirements; removed inhand items from ChemistGear.
Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml Expanded access permissions; removed inhand items from CMOGear.
Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml Updated access; removed inhand items from DoctorGear.
Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml Added canBeAntag property; removed inhand items from MedicalInternGear.
Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml Expanded starting gear; removed inhand items from ParamedicGear.
Resources/Prototypes/Roles/Jobs/Medical/senior_physician.yml Disabled role selection preference; removed inhand items from SeniorPhysicianGear.
Resources/Prototypes/Roles/Jobs/Science/research_assistant.yml Commented out requirements; added canBeAntag property; removed inhand items.
Resources/Prototypes/Roles/Jobs/Science/research_director.yml Updated departmental requirements; removed inhand items from ResearchDirectorGear.
Resources/Prototypes/Roles/Jobs/Science/roboticist.yml Updated requirements; removed inhand items from RoboticistGear.
Resources/Prototypes/Roles/Jobs/Science/scientist.yml Changed department; removed inhand items from ScientistGear.
Resources/Prototypes/Roles/Jobs/Science/senior_researcher.yml Updated department; removed inhand items from SeniorResearcherGear.
Resources/Prototypes/Roles/Jobs/Security/detective.yml Removed Brig access; updated starting gear; removed inhand items.
Resources/Prototypes/Roles/Jobs/Security/head_of_security.yml Removed Brig access; updated starting gear; removed inhand items.
Resources/Prototypes/Roles/Jobs/Security/security_cadet.yml Simplified requirements; removed Brig access; updated outerClothing; removed inhand items.
Resources/Prototypes/Roles/Jobs/Security/security_officer.yml Removed Brig access; updated outerClothing; removed inhand items.
Resources/Prototypes/Roles/Jobs/Security/senior_officer.yml Removed Brig access; updated outerClothing; removed inhand items.
Resources/Prototypes/Roles/Jobs/Security/warden.yml Updated access requirements; removed inhand items.

Suggested labels

Changes: C#


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7c4566f and d1ee8f7.

📒 Files selected for processing (40)
  • Resources/Prototypes/Roles/Jobs/Cargo/cargo_technician.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Cargo/quartermaster.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Cargo/salvage_specialist.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/assistant.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/bartender.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/botanist.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/chaplain.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/chef.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/clown.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/janitor.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/lawyer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/librarian.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/mime.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/musician.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Civilian/service_worker.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Command/captain.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Command/centcom_official.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Command/head_of_personnel.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Engineering/atmospheric_technician.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Engineering/chief_engineer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Engineering/senior_engineer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Engineering/station_engineer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Engineering/technical_assistant.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Medical/chemist.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Medical/senior_physician.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Science/research_assistant.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Science/research_director.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Science/roboticist.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Science/scientist.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Science/senior_researcher.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Security/detective.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Security/head_of_security.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Security/security_cadet.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Security/security_officer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Security/senior_officer.yml (0 hunks)
  • Resources/Prototypes/Roles/Jobs/Security/warden.yml (0 hunks)
💤 Files with no reviewable changes (40)
  • Resources/Prototypes/Roles/Jobs/Cargo/cargo_technician.yml
  • Resources/Prototypes/Roles/Jobs/Cargo/quartermaster.yml
  • Resources/Prototypes/Roles/Jobs/Cargo/salvage_specialist.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/assistant.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/bartender.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/botanist.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/chaplain.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/chef.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/clown.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/janitor.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/lawyer.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/librarian.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/mime.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/musician.yml
  • Resources/Prototypes/Roles/Jobs/Civilian/service_worker.yml
  • Resources/Prototypes/Roles/Jobs/Command/captain.yml
  • Resources/Prototypes/Roles/Jobs/Command/centcom_official.yml
  • Resources/Prototypes/Roles/Jobs/Command/head_of_personnel.yml
  • Resources/Prototypes/Roles/Jobs/Engineering/atmospheric_technician.yml
  • Resources/Prototypes/Roles/Jobs/Engineering/chief_engineer.yml
  • Resources/Prototypes/Roles/Jobs/Engineering/senior_engineer.yml
  • Resources/Prototypes/Roles/Jobs/Engineering/station_engineer.yml
  • Resources/Prototypes/Roles/Jobs/Engineering/technical_assistant.yml
  • Resources/Prototypes/Roles/Jobs/Medical/chemist.yml
  • Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml
  • Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml
  • Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml
  • Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml
  • Resources/Prototypes/Roles/Jobs/Medical/senior_physician.yml
  • Resources/Prototypes/Roles/Jobs/Science/research_assistant.yml
  • Resources/Prototypes/Roles/Jobs/Science/research_director.yml
  • Resources/Prototypes/Roles/Jobs/Science/roboticist.yml
  • Resources/Prototypes/Roles/Jobs/Science/scientist.yml
  • Resources/Prototypes/Roles/Jobs/Science/senior_researcher.yml
  • Resources/Prototypes/Roles/Jobs/Security/detective.yml
  • Resources/Prototypes/Roles/Jobs/Security/head_of_security.yml
  • Resources/Prototypes/Roles/Jobs/Security/security_cadet.yml
  • Resources/Prototypes/Roles/Jobs/Security/security_officer.yml
  • Resources/Prototypes/Roles/Jobs/Security/senior_officer.yml
  • Resources/Prototypes/Roles/Jobs/Security/warden.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PuroSlavKing
Copy link
Member

Сделай вкладку сезонного лодаута, и туда ебани эту корзинку. Решение проблемы, без потери контента

@Spatison
Copy link
Member

Spatison commented Nov 5, 2024

Скоро уже почти неделя с конца хэлуина, думаю можно сразу и декорации с карт убрать

@Remuchi Remuchi merged commit 7b39628 into WWhiteDreamProject:master Nov 6, 2024
10 of 11 checks passed
@Gersoon458 Gersoon458 deleted the UbratHalloweenIzRuk branch November 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants