Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert translations #122

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

unkima
Copy link
Contributor

@unkima unkima commented Nov 8, 2024

Описание PR

Переведены некоторые оповещения.


Изменения

🆑

  • no cl no fun

Copy link
Contributor

coderabbitai bot commented Nov 8, 2024

Walkthrough

This pull request introduces several new localization strings for Russian language resources related to various station events. It includes announcements regarding noospheric storms, vent clogging, and multiple types of creatures within the station's ventilation systems. Additionally, it adds warnings about hostile alien fauna, enhancing the game's localization for Russian-speaking players by providing critical event-related information.

Changes

File Path Change Summary
Resources/Locale/ru-RU/psionics/noospheric-storm.ftl Added string station-event-noospheric-storm-announcement.
Resources/Locale/ru-RU/station-events/events/vent-clog.ftl Added entry station-event-vent-clog-announcement.
Resources/Locale/ru-RU/station-events/events/vent-critters.ftl Added multiple entries: station-event-cockroach-migration-announcement, station-event-slimes-spawn-announcement, station-event-vent-critters-announcement, station-event-spider-spawn-announcement, station-event-reagentslime-vents-announcement, station-event-meat-vents-announcement, station-event-neutral-xeno-vents-announcement, station-event-tick-vents-announcement, station-event-argocyte-vents-announcement, station-event-light-vents-announcement, station-event-carp-vents-announcement, station-event-space-vents-announcement, station-event-slimes-spawn-weak-announcement, station-event-spider-spawn-weak-announcement.
Resources/Locale/ru-RU/station-events/events/xeno-vent.ftl Added strings station-event-xeno-vents-announcement and station-event-xeno-vents-weak-announcement.

Possibly related PRs

  • [Fix] Ru Loc / Локализация #51: This PR involves the addition of new translations in Russian localization files, which is directly related to the main PR's focus on enhancing localization for Russian-speaking users.
  • [Fix] Localizations / Локализация #92: Although primarily focused on fixing English localization, it involves modifications to the localization system that could indirectly relate to the overall localization efforts, including Russian.

Suggested labels

Changes: Localization

Suggested reviewers

  • Remuchi

Warning

Tool Failures:

Tool Failure Count:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (2)
Resources/Locale/ru-RU/station-events/events/xeno-vent.ftl (1)

1-2: LGTM! Consider adding line breaks for better source readability.

The Russian translations are accurate and effectively convey both the confirmed and suspected xeno threat scenarios while maintaining appropriate tone and clarity in the instructions.

Consider breaking the long lines for better readability in the source file:

-station-event-xeno-vents-announcement = Подтверждено наличие на станции враждебной чужеродной фауны. Персоналу рекомендуется вооружиться, забаррикадировать двери и защищаться в случае необходимости. Службе безопасности следует как можно скорее ликвидировать угрозу.
+station-event-xeno-vents-announcement = 
+    Подтверждено наличие на станции враждебной чужеродной фауны. 
+    Персоналу рекомендуется вооружиться, забаррикадировать двери и защищаться в случае необходимости. 
+    Службе безопасности следует как можно скорее ликвидировать угрозу.

-station-event-xeno-vents-weak-announcement = На станции зафиксированы предположительные признаки враждебной чужеродной фауны. Персоналу рекомендуется вооружиться, забаррикадировать двери и защищаться в случае необходимости. Службе безопасности следует как можно скорее ликвидировать угрозу.
+station-event-xeno-vents-weak-announcement = 
+    На станции зафиксированы предположительные признаки враждебной чужеродной фауны. 
+    Персоналу рекомендуется вооружиться, забаррикадировать двери и защищаться в случае необходимости. 
+    Службе безопасности следует как можно скорее ликвидировать угрозу.
Resources/Locale/ru-RU/station-events/events/vent-critters.ftl (1)

14-14: Improve section header documentation.

The comment "# Weak" should be:

  1. Translated to Russian for consistency
  2. More descriptive about its purpose

Consider replacing with:

-# Weak
+# Слабые существа - объявления о существах низкого уровня угрозы
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cd020a9 and 7f1e1b7.

📒 Files selected for processing (4)
  • Resources/Locale/ru-RU/psionics/noospheric-storm.ftl (1 hunks)
  • Resources/Locale/ru-RU/station-events/events/vent-clog.ftl (1 hunks)
  • Resources/Locale/ru-RU/station-events/events/vent-critters.ftl (1 hunks)
  • Resources/Locale/ru-RU/station-events/events/xeno-vent.ftl (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Resources/Locale/ru-RU/psionics/noospheric-storm.ftl
🔇 Additional comments (1)
Resources/Locale/ru-RU/station-events/events/vent-critters.ftl (1)

8-13: LGTM! Well-structured threat level differentiation.

The announcements effectively:

  • Distinguish between neutral and hostile fauna
  • Provide clear instructions for both general personnel and security
  • Maintain consistent message structure while varying the threat description

@Remuchi Remuchi merged commit 4072e44 into WWhiteDreamProject:master Nov 14, 2024
10 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants