Reenable Executions #126
Reenable Executions #126
Conversation
WalkthroughThe changes in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
Content.Server/Execution/ExecutionSystem.cs (1)
210-225: LGTM: Well-implemented shoot attempt event systemGood addition of the
AttemptShootEventsystem that:
- Allows other systems to cancel the shot
- Provides proper user feedback via popups
- Follows event-driven architecture patterns
Consider extracting the message handling into a separate method for better reusability:
+ private void HandleAttemptShootEvent(EntityUid weapon, EntityUid attacker, AttemptShootEvent attemptEv) + { + if (attemptEv.Cancelled && attemptEv.Message != null) + { + _popupSystem.PopupEntity(attemptEv.Message, weapon, attacker); + } + } private void TryStartGunExecutionDoafter(EntityUid weapon, EntityUid victim, EntityUid attacker) { // ... existing code ... var attemptEv = new AttemptShootEvent(attacker, null); RaiseLocalEvent(weapon, ref attemptEv); - if (attemptEv.Cancelled) - { - if (attemptEv.Message != null) - { - _popupSystem.PopupEntity(attemptEv.Message, weapon, attacker); - return; - } - } + HandleAttemptShootEvent(weapon, attacker, attemptEv); + if (attemptEv.Cancelled) + return;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
Content.Server/Execution/ExecutionSystem.cs(3 hunks)
🔇 Additional comments (1)
Content.Server/Execution/ExecutionSystem.cs (1)
46-46: Consider the balance implications of increased damage multiplier
The damage modifier has been significantly increased from 9.0f to 20.0f, which more than doubles the execution damage. This substantial increase could lead to gameplay balance issues and might make executions overly lethal.
Let's analyze the typical damage values this would affect:
Consider implementing a configuration system to make this value adjustable without code changes, allowing for easier balance tweaks.
✅ Verification successful
Execution damage multiplier increase appears to be an intentional balance change
The increase from 9.0f to 20.0f, while significant, aligns with the lethal nature of executions and is marked as a deliberate "WD EDIT" balance adjustment. The new multiplier value remains within reasonable bounds compared to other lethal damage values in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for base damage values in weapon definitions
rg -A 3 "Damage\s*=|damage\s*:" --type yaml
Length of output: 492119
Описание PR
Описание.
убийства
Изменения
🆑 vanx